fix: honor SOT-23 builder pin counts - #864
Open
ardaerturk wants to merge 1 commit into
Open
ardaerturk wants to merge 1 commit into
ardaerturk wants to merge 1 commit into
Conversation
Author
|
Following up on this September 4 fix for SOT-23 builder pin counts. The four recorded CI checks pass, and the PR includes the regression tests and SVG snapshots described above. Could a maintainer review it or let me know if a revision is needed? Please also confirm whether this contribution would be eligible for contributor rewards if merged; I have not assumed a fixed bounty. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The fluent SOT-23 builder silently ignored its pin-count argument:
fp().sot23(5),(6), and(8)all generated three pads, while the corresponding string definitions produced the correct footprints. Read the builder count when no count is supplied by the string, and expose the optional argument in the TypeScript signature. Unsupported counts now reach the existing validation instead of silently selecting three pins.Validation: four regression cases fail before the fix; all 570 tests pass after it. The ESM/declaration build and changed-file Biome check pass. Added and visually reviewed SVG snapshots for the supported pin counts, as required by AGENTS.md.
AI-assisted with Codex; verified with runtime tests, geometry comparisons against the existing string API, and visual snapshots.