Fix origins for rotated SMT pads - #869
seunghyukchoe wants to merge 2 commits into
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 50b9fc4d42
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
Codex Review: Didn't find any major issues. Can't wait for the next one! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Combining
pin1location(...)withorigin("bottomleft")currently measures rotated SMT pads using their unrotated width and height. For example:The resulting copper starts at x = +0.2 mm, y = -0.2 mm instead of (0, 0).
Calculate the rotated copper bounds for rectangular and pill-shaped SMT pads, respecting
corner_radius, the legacyrect_border_radius, and pillradius. This also handles non-quarter-turn angles with rounded corners.Validation on macOS arm64 with Bun 1.3.14, against upstream
d0d2ee19:bun test --timeout 30000). The longer timeout accommodates remote KiCad reference downloads; four default-timeout failures on unchanged upstream passed when retried.bun run build,bunx biome format ., andgit diff --checkpass. Formatting was checked before generatingdist.Related origin work: #867 and #868.
Prepared with OpenAI Codex assistance, including an independent code review. I can respond to review feedback and revise the change.