fix: include plated slot copper dimensions in origin bounds - #870
Open
ByungDooJang wants to merge 1 commit into
Open
ByungDooJang wants to merge 1 commit into
ByungDooJang wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Calling
fp.string("usbcmidmount16").origin("bottomleft").circuitJson()places the leftmost copper edge at -0.6 mm and the bottom copper edge at -0.9 mm. The plated shell slots exposeouter_widthandouter_height, butapplyOriginonly reads circular diameters, so it counts each slot as a point.Use the outer width and height when present, retaining the existing diameter fallback for circular holes. The regression test checks that the generated connector's left and bottom copper edges reach zero and includes an SVG snapshot.
Validation on Windows x64:
smf,parity/sod523, anddiode-kicad-parity/sod523image mismatches reproduce with the unmodified helper (17 passed, 3 failed across those three files).bun run buildand formatting of the changed files pass. New SVG was rendered and visually inspected.This change is limited to the dimensions used for the existing axis-aligned bounds calculation; it does not add rotation-aware geometry or change the separate rectangular-pad logic proposed in #384.
Prepared with OpenAI Codex assistance and checked with the tests above.