Conversation
Previously, calling fp.string('solderjumper') without a pin count
left num_pins as undefined, causing all geometry derived from
(num_pins - 1) * padSpacing to be NaN. The courtyard and silkscreen
text silently contained NaN coordinates.
Now num_pins defaults to 2 when not provided, matching the behavior
of solderjumper2 and most other footprints that accept a pin count.
Fixes tscircuit#784
Yingtm
force-pushed
the
fix/solderjumper-default-pins
branch
from
September 8, 2026 15:19
dc79785 to
10877c3
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #784
Calling
fp.string("solderjumper")without a pin count leftnum_pinsasundefined, causing every value derived from(num_pins - 1) * padSpacingto beNaN. The courtyard rect and silkscreen text silently containedNaN/nullcoordinates.Fix
Made
num_pinsoptional in the function signature and default it to2via destructuring, matching the behavior ofsolderjumper2and most other footprints that accept a pin count.Testing
bare solderjumper defaults to 2 pins