Skip to content

Connect schematic components to focused PCB view - #4668

Closed
0hmX wants to merge 2 commits into
mainfrom
codex/go-to-pcb-view
Closed

0hmX wants to merge 2 commits into
mainfrom
codex/go-to-pcb-view

Conversation

@0hmX

@0hmX 0hmX commented Aug 20, 2026

Copy link
Copy Markdown
Contributor

Summary

Completes schematic-to-PCB component navigation in CircuitJsonPreview.

  • handles schematic navigation callbacks at the tab-owning host boundary
  • stores a monotonically increasing PCB focus request so repeated navigation retriggers focus
  • switches through the existing active-tab setter, preserving onActiveTabChange
  • forwards controlled focus requests to PCBViewer
  • exposes navigation only when the PCB tab is available
  • adds a fixture with widely separated top- and bottom-layer components
  • covers tab switching and repeat-request behavior

PR chain

Part 3 of 3 — integration PR.

  1. tscircuit/schematic-viewer#262 — navigation callback
  2. tscircuit/pcb-viewer#963 — controlled component focus
  3. This PR: runframe tab and focus integration

Dependency order

This draft depends on parts 1 and 2 being merged and released. After those releases, update runframe's @tscircuit/schematic-viewer and @tscircuit/pcb-viewer versions before marking this ready for review.

Validation

Validated with the two upstream worktrees linked locally:

  • bun test — 47 passed
  • formatting check
  • TypeScript check
  • package and standalone builds
  • live fixture verified for top- and bottom-layer focus with zero browser console errors

@vercel

vercel Bot commented Aug 20, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
runframe Ready Ready Preview Aug 20, 2026 3:11pm

Request Review

@github-actions

Copy link
Copy Markdown
Contributor

This PR has been automatically marked as stale because it has had no recent activity. It will be closed if no further activity occurs.

@github-actions

Copy link
Copy Markdown
Contributor

This PR was closed because it has been inactive for 1 day since being marked as stale.

@github-actions github-actions Bot closed this Aug 25, 2026

This branch was successfully deployed

1 active deployment
Preview 33b1d1b5 Deployed Aug 20, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant