Skip to content

Fix horizontal fallback bounds for rail net labels - #1007

Open
techmannih wants to merge 2 commits into
mainfrom
fix/trellis-core-gnd-net-label-overlap
Open

Fix horizontal fallback bounds for rail net labels#1007
techmannih wants to merge 2 commits into
mainfrom
fix/trellis-core-gnd-net-label-overlap

Conversation

@techmannih

Copy link
Copy Markdown
Member

Summary

  • preserve the rendered text width when a vertical-only rail label falls back to a horizontal pin-facing placement
  • give the label collision solver truthful bounds so GND is moved clear of VRA2 and P1V8 in the merged Trellis Core repro (test: add Trellis Core GND net label overlap repro #1003)
  • update all affected solver snapshots

Testing

  • bun test (292 passed, 4 skipped)
  • bunx tsc --noEmit
  • bunx biome format on changed TypeScript files
  • visually inspected the Trellis Core solver snapshot and final collision stage

@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.

@vercel

vercel Bot commented Sep 1, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
schematic-trace-solver Ready Ready Preview Sep 1, 2026 7:27am UTC

Request Review

@MustafaMulla29 MustafaMulla29 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure what this fixes, can you show me before and after image from core if there is a repro.

@techmannih

Copy link
Copy Markdown
Member Author

@MustafaMulla29 repro #1005
tscircuit/core#3566

Before

Screenshot 2026-09-01 at 18 13 54

After
Screenshot 2026-09-01 at 18 13 40

@MustafaMulla29

Copy link
Copy Markdown
Contributor

I don't think this is an improvement

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants