Reroute component-to-component traces around avoidable label-trace crossings - #1013
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Abse2001
approved these changes
Sep 1, 2026
imrishabh18
requested changes
Sep 1, 2026
imrishabh18
left a comment
Member
There was a problem hiding this comment.
Don't use string matching hack's
This reverts commit 629b867.
MustafaMulla29
force-pushed
the
fix/post-label-cross-net-crossings
branch
from
September 1, 2026 14:45
2a966c0 to
1844666
Compare
MustafaMulla29
requested review from
imrishabh18 and
seveibar
and removed request for
imrishabh18
September 1, 2026 15:47
imrishabh18
approved these changes
Sep 1, 2026
…net-crossings # Conflicts: # lib/solvers/AvailableNetOrientationSolver/AvailableNetOrientationSolver.ts # lib/solvers/SchematicTracePipelineSolver/SchematicTracePipelineSolver.ts
Contributor
|
Thank you for your contribution! 🎉 PR Rating: ⭐⭐⭐ Track your contributions and see the leaderboard at: tscircuit Contribution Tracker |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Root cause
Component-to-component traces are routed before generated net-label connectors are added to the pipeline. A later connector can therefore cross an already-routed component trace even when that component trace has an equally short clean corridor.
Crossings between two generated label connectors are valid and remain unchanged.
Solution
generatePerpendicularTraceDetoursrouting primitive, extended with optional bounds so an attached label and its connector form one obstacleThe previous standalone 331-line candidate generator has been removed. The cleanup now uses a compact coordinator around the existing routing primitive.
Result
Verification
bun test --timeout 20000— 297 passed, 4 skipped, 0 failedbunx tsc --noEmitbun run formatgit diff --check