Add SparkFun Qwiic Shim repro for over-distance GND trace - #983
Open
rushabhcodes wants to merge 2 commits into
Open
Add SparkFun Qwiic Shim repro for over-distance GND trace#983rushabhcodes wants to merge 2 commits into
rushabhcodes wants to merge 2 commits into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
seveibar
requested changes
Aug 29, 2026
seveibar
left a comment
seveibar
left a comment
Contributor
There was a problem hiding this comment.
we're not merging anything that isn't related to real targets for a real board
Contributor
Author
|
this is from a board i am working on |
rushabhcodes
changed the title
rushabhcodes
commented
Aug 29, 2026
rushabhcodes
left a comment
rushabhcodes
left a comment
Contributor
Author
There was a problem hiding this comment.
found this bug across sparkfun boards repo
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a minimal visual reproduction extracted from SparkFun Qwiic Shim for Raspberry Pi.
The fixture keeps only the three components needed to reproduce the issue: regulator
U2and capacitorsC1andC3. It preserves their board schematic coordinates and their shared GND net.View the SVG snapshot
Bug
LongDistancePairSolveremits a physical trace fromC3.2toU2.GNDwith a Manhattan distance of 3.8 schematic units, despitemaxMspPairDistancebeing 2.4. The distant C3 endpoint should use a GND net label instead.The distance fallback is currently applied only when the matching named net contains exactly two pins:
GND contains three pins here (
U2.GND,C1.2, andC3.2), so that guard is skipped and the over-distance pair is accepted.The test checks the exact offending pin pair and distance as well as preserving the visual snapshot.
Scope
Reproduction and snapshot only; no solver behavior is changed.
Validation
bun test tests/repros/repro-multi-pin-ground-max-distance.test.tsbun run format:checkbun run build