Conversation
|
@ugin-man is attempting to deploy a commit to the tscircuit Team on Vercel. A member of the Team first needs to authorize it. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
_step()reports a failure on the last allowed iteration,BaseSolver.step()still invokestryFinalAcceptance()and can overwrite the specific error with an iteration-limit message. An accepting hook can even leave the solver both solved and failed. An explicit rejection insidetryFinalAcceptance()also loses its error.Run final acceptance and the exhaustion fallback only while the solver is neither solved nor failed. Normal iteration exhaustion and successful final acceptance continue to work.
Validation: three new regression tests fail before the change; all 26 tests (102 assertions) pass after it, including the existing exhaustion test and a new successful-acceptance check.
tsc --noEmitandbun run buildpass.Prepared with Codex (Astra) assistance and verified locally.