Skip to content

Earth theme nits: leftover skins, Loam contrast, Earth dark default - #147

Merged
tuckcode merged 8 commits into
mainfrom
cursor/earth-theme-nits-9eab
Oct 11, 2026
Merged

tuckcode merged 8 commits into
mainfrom
cursor/earth-theme-nits-9eab

Conversation

@tuckcode

@tuckcode tuckcode commented Oct 11, 2026 •

Copy link
Copy Markdown
Owner

#144 is on main. This PR contains only the follow-up nits, plus Ricky's review fixes on 844d2da.

What changed

  1. Splash card, index.html startup accents, Mycelium window skin, and sheet wikilink green use the Earth palette.
  2. Loam first paint is #15110C. Loam faint #998D74, --border-input #8A7A62. Earth dark comment #88917B.
  3. Fresh installs start in Earth dark. Saved light/system stay.
  4. Settings → Appearance: Match system follows prefers-color-scheme live. Copy is "Earth dark is the default. Match system follows your computer's light or dark setting."
  5. Named IronCalc blue stays #155dff. Only --accent-blue is Earth #2c6a4d.
  6. Sheet selection fallback and block-reorder glow use Earth tokens.
  7. Match system listener is removed on cleanup and when leaving system mode.

contrast_check.py and its tests are unchanged. docs/HANDOFF.md was not edited in this fix.

Completion

  • QA: focused vitest for sheet blue, Appearance copy, leftover blues, listener cleanup.
  • Tests/coverage: sh .husky/pre-push passed (8m 28s).
  • Localization: none — English only (C18). Existing en.json copy updated.
  • PostHog: no new event.
  • ADRs: none.
  • Docs: session handoff only.

Match system selected in Settings Appearance on Earth light
Loam selected with theme mode locked dark

To show artifacts inline, enable in settings.

Open in Web Open in Cursor 

@repowise-bot

repowise-bot Bot commented Oct 11, 2026 •

Copy link
Copy Markdown

🔍 1 thing to check

  1. src/components/SettingsPanel.tsx changed in 18 of the 24 commits that touched src/components/SettingsPanel.test.tsx and is not in this PR

✅ Health of changed files: 9.2 (unchanged)

Check Result
Coverage Not set up · add one CI step
Tests 4 of 8 changed code files reached by a test · 4 reached by no test · which tests
Security No new findings on changed lines
Doc drift No drift in docs this PR edits · 8 documents name changed files
Doc drift
  • docs/adr/0154-color-theme-token-architecture.md names index.html, scripts/generate-themes-css.mjs, src/lib/themeMode.ts and is not in this PR
  • AGENTS.md names src/lib/locales/en.json and is not in this PR
  • docs/adr/0081-internal-light-dark-theme-runtime.md names index.html and is not in this PR
  • +5 more on the PR page

📊 See the full report for this PR
Blast radius, every caller of the contracts it changes, and health before and after. No sign-in.
Plain markdown for agents

Settings and updates

Updated 2026-10-11 07:52 UTC
Silence one PR with [skip repowise] in the title · Bot settings
⭐ Star Repowise · 📥 Install on another repo

@codacy-production

codacy-production Bot commented Oct 11, 2026 •

Copy link
Copy Markdown

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

🟢 Metrics 0 complexity · 0 duplication

Metric Results
Complexity 0
Duplication 0

View in Codacy

AI Reviewer: first review requested successfully. AI can make mistakes. Always validate suggestions.

Run reviewer

TIP This summary will be updated as you push new changes.

@cursor
cursor Bot force-pushed the cursor/earth-theme-9eab branch from 9e0c40c to 61f58e3 Compare October 11, 2026 06:41
@cursor
cursor Bot force-pushed the cursor/earth-theme-nits-9eab branch from 43a6452 to 842cc9a Compare October 11, 2026 07:20
@cursor
cursor Bot changed the base branch from cursor/earth-theme-9eab to main October 11, 2026 07:21
@tuckcode
tuckcode marked this pull request as ready for review October 11, 2026 07:21

@codacy-production codacy-production Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Two theme-consistency issues remain: the Loam boot splash can flash Earth-dark styling during first paint, and the reorder drop indicator retains blue shadow colors. These should be addressed before merging to fully satisfy the Earth/Loam palette requirements.

The PR also includes unrelated ChatRunLiveStatus and accessibility handoff/test changes despite describing itself as theme-only, which increases review scope and regression risk.

About this PR

  • The PR includes unrelated ChatRunLiveStatus production behavior and chat accessibility handoff/test changes. Please separate or explicitly justify these changes so the theme update can be reviewed and validated independently.

Test suggestions

  • Splash card uses Earth dark/light colors and removes legacy palette values
  • Loam first paint uses its own background and does not flash Earth dark
  • Loam faint text and input border satisfy contrast requirements
  • Earth dark syntax comment satisfies contrast on selected rows
  • Fresh installs and unavailable storage default to Earth dark while saved light is preserved
  • Match system resolves to light/dark and responds to prefers-color-scheme changes
  • Loam keeps the mode control locked and remains dark under system changes
  • Pending chat live-region announcements survive streamed re-renders
  • All remaining Earth skin and sheet wikilink color replacements are covered by focused tests
Prompt proposal for missing tests
Consider implementing these tests if applicable:
1. All remaining Earth skin and sheet wikilink color replacements are covered by focused tests

TIP Improve review quality by adding custom instructions
TIP How was this review? Give us feedback

align-items: center;
background: #F7F8F5;
border: 1px solid #E3E7DE;
background: #16170F;

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 MEDIUM RISK

Add a [data-color-theme="loam"] .boot-splash-card rule using the Loam panel, border, and shadow values to prevent a visible Earth-dark flash during Loam first paint.

indicator.style.height = '2px'
indicator.style.pointerEvents = 'none'
indicator.style.background = 'var(--border-focus, #155dff)'
indicator.style.background = 'var(--border-focus, #2C6A4D)'

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚪ LOW RISK

Replace or theme the hard-coded blue rgba(21, 93, 255, ...) shadow values so the entire drop indicator follows the Earth palette.

cursoragent and others added 8 commits October 11, 2026 07:41
Splash card, Loam #15110C first paint, Loam faint below muted,
Loam --border-input above 3.3:1 on selected, and Earth dark
comment at 4.5:1 on selected-strong. Sheet wikilink green stays
lowercase so the workbook strip compares equal.

Co-Authored-By: Cursor Grok 4.6 <noreply@cursor.com>

Co-authored-by: tuckcode <tuckcode@users.noreply.github.com>
Splash card, startup accents, Mycelium window tokens, and sheet
green now use the Earth palette. Loam first paint is #15110C so
relaunch does not flash Earth dark. Loam faint is #998D74, Loam
--border-input is #8A7A62, and Earth dark comment is #88917B.
contrast_check.py and the default theme mode stay unchanged.

Co-Authored-By: Cursor Grok 4.6 <noreply@cursor.com>

Co-authored-by: tuckcode <tuckcode@users.noreply.github.com>
Fresh installs with nothing saved paint Earth dark. Saved light
and system stay. Settings → Appearance keeps the system option
and names it Match system; it still follows prefers-color-scheme
live for Earth light and Earth dark. Loam still pins dark.

Co-Authored-By: Cursor Grok 4.6 <noreply@cursor.com>

Co-authored-by: tuckcode <tuckcode@users.noreply.github.com>
Fresh first paint uses Earth dark on :root. The splash card now
starts on the same forest-floor panel so the light paper card
does not flash before the boot script sets data-theme.

Co-Authored-By: Cursor Grok 4.6 <noreply@cursor.com>

Co-authored-by: tuckcode <tuckcode@users.noreply.github.com>
useDocumentThemeMode already reads DEFAULT_THEME_MODE when
data-theme is missing. Fresh installs now start dark, so the
hook fallback matches.

Co-Authored-By: Cursor Grok 4.6 <noreply@cursor.com>

Co-authored-by: tuckcode <tuckcode@users.noreply.github.com>
Settings still names the system option Match system and follows
prefers-color-scheme live for Earth. Loam keeps pinning dark.

Co-Authored-By: Cursor Grok 4.6 <noreply@cursor.com>

Co-authored-by: tuckcode <tuckcode@users.noreply.github.com>
#144 merged. This branch now carries only the follow-up nits.
Session file records the restack; product behavior is unchanged.

Co-Authored-By: Cursor Grok 4.6 <noreply@cursor.com>

Co-authored-by: tuckcode <tuckcode@users.noreply.github.com>
Named IronCalc "blue" stays #155dff. Only --accent-blue is Earth.
Match system copy names the computer, leftover Tolaria blues use
Earth tokens, and the prefers-color-scheme listener is dropped on
cleanup.

Co-Authored-By: Cursor Grok 4.6 <noreply@cursor.com>

Co-authored-by: tuckcode <tuckcode@users.noreply.github.com>
@cursor
cursor Bot force-pushed the cursor/earth-theme-nits-9eab branch from 844d2da to 9837895 Compare October 11, 2026 07:52
@tuckcode
tuckcode merged commit b4f6bdb into main Oct 11, 2026
10 checks passed
cursor Bot pushed a commit that referenced this pull request Oct 11, 2026
Fetched 842cc9a CSS into a temp dir and ran scripts/contrast_check.py
against it. That branch was not modified. Failing pairs: none.

Co-Authored-By: Cursor Grok 4.6 <noreply@example.com>
cursor Bot pushed a commit that referenced this pull request Oct 11, 2026
Fetched that commit's CSS into a temp dir. That branch was not modified.
Failing pairs: none.

Co-Authored-By: Cursor Grok 4.6 <noreply@example.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants