Repository navigation
fix: boot splash never freezes with arms missing - #151
Merged
Merged
Conversation
Up to standards ✅🟢 Issues
|
There was a problem hiding this comment.
Pull Request Overview
The required automated scenarios are covered except native Mac/Tauri launch validation, so the platform-specific acceptance criterion remains unverified. No code, security, complexity, or Codacy issues were reported.
About this PR
- Validate the splash during a native Mac/Tauri launch to confirm that the arms grow and the logo pulses as required.
Test suggestions
- Hidden at first paint keeps boot motion running
- Visibility change to visible resumes motion
- A later hide pauses motion and showing the page resumes it
- Paused CSS disables grow-in animations so all arms remain visible
- Reduced-motion CSS disables animations while retaining the settled logo
- Native Mac/Tauri launch confirms arms grow and logo pulses
Prompt proposal for missing tests
Consider implementing these tests if applicable:
1. Native Mac/Tauri launch confirms arms grow and logo pulses
TIP Improve review quality by adding custom instructions
TIP How was this review? Give us feedback
A Tauri/WebKit window often reports document.hidden at first paint. Pausing grow-in there, with fill:both from opacity 0, left two arms invisible if visibilitychange never fired. Stay running until the page has been visible once. Paused and reduced-motion states drop the grow animations so the settled mark stays on screen. Co-Authored-By: Cursor Grok 4.6 <noreply@cursor.com> Co-authored-by: tuckcode <tuckcode@users.noreply.github.com>
cursor
Bot
force-pushed
the
cursor/boot-splash-frozen-arms-60e9
branch
from
October 11, 2026 08:18
8666819 to
b645a34
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A Tauri/WebKit window on macOS often reports
document.hiddenat first paint. The splash then set--boot-motion-state: pausedwhile the grow-in arms useanimation-fill-mode: bothfrom opacity 0. Ifvisibilitychangenever fires when the window is shown, those two arms stay invisible and the breathe pulse stays frozen.This change keeps motion running until the page has actually been visible once. After that, a later hide can still pause. Paused and
prefers-reduced-motion: reduceboth drop the grow animations so the full settled logo stays on screen.Rebased onto
mainafter #150. Handoff note isdocs/plans/handoffs/2026-10-11-0815-cursor-grok-4-6-boot-splash-arms.mdonly —docs/HANDOFF.mdis not edited.Mac rebuild check: launch the app; the two arms grow in and the logo pulses; with Reduce Motion on, the full logo shows still.
What changed
index.htmlno longer pauses grow-in just because the first paint is hidden.visibilitychangeto visible still resumes motion.BootSplash.cssshows the settled mark when paused or when motion is reduced.Completion
pnpm exec vitest run src/index.bootMotion.test.ts src/components/BootSplash.test.tsx— 10 passed. Frontend lane (pnpm lint && pnpm typecheck && pnpm build && coverage shards && pnpm test:mcp) passed: 88.44% lines (threshold 70%), 106 mcp tests.sh .husky/pre-pushitself skipped app checks because the branch was already on the remote (empty@{push}..HEAD). Rust skipped (nosrc-tauri/change).docs/plans/handoffs/2026-10-11-0815-cursor-grok-4-6-boot-splash-arms.md.docs/HANDOFF.mdleft unchanged (docs: stop PRs from conflicting in HANDOFF.md #150).