[pull] master from php:master - #1249
Merged
Merged
Conversation
Add a failure-reporting double conversion API analogous to zval_try_get_long(). Non-convertible values set the failure flag instead of being silently coerced. Use zval_try_get_long()-compatible numeric-string semantics, including warnings for trailing data, while preserving signed zero. Document that the return value must not be used on failure and that an exception may already be pending.
This file only wires up GDB debugging helpers, so covering it isn't useful.
…esponse_headers_parse()
… usage (#21570) Headers required by the generated code (zend_attributes.h, zend_constants.h, zend_enum.h) are collected during generation and emitted as includes at the top of the arginfo file, with the same preprocessor conditions and PHP version guards as the code that needs them. Removes the manual zend_attributes.h and zend_enum.h includes from sources that only needed them for the arginfo file they include.
The destructor of a statement created with [PDO::ATTR_CURSOR => PDO::CURSOR_SCROLL] tried to close the cursor even when it did not exist. The attempted close causes an error on the server that the destructor discards, so it cannot be observed by the user, but inside a transaction it leaves subsequent statements failing for a reason nobody can see. is_prepared was overloaded to also mean "cursor declared" and was never reset, so the cursor state now has its own flag. A close that fails no longer aborts the caller's transaction. Close GH-23490
* PHP-8.4: ext/pdo_pgsql: Fix CURSOR_SCROLL statements closing a nonexistent cursor # Conflicts: # ext/pdo_pgsql/pgsql_statement.c # ext/pdo_pgsql/php_pdo_pgsql_int.h
* PHP-8.5: ext/pdo_pgsql: Fix CURSOR_SCROLL statements closing a nonexistent cursor # Conflicts: # ext/pdo_pgsql/config.m4 # ext/pdo_pgsql/pgsql_statement.c
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )