[pull] master from php:master - #1253
Merged
Merged
Conversation
commit 33b13ae Author: Michael Orlitzky <michael@orlitzky.com> Date: Tue Sep 1 17:58:13 2026 -0400 ext/session/.../gh23043.phpt: session.save_path can be nonempty Allow session.save_path to be nonempty in this test, as the test itself does not empty it, and in automated setups it is common to force all "temporary stuff" to a dedicated location. Closes GH-23537
schema_content_model_fixup() and schema_attributegroup_fixup() followed a group ref back into schema_type_fixup() with nothing tracking the types already being fixed up, so a schema whose group references itself recursed until the C stack ran out. Track the in-progress types in the sdl context and raise a parse error when one is re-entered. Closes GH-23600
* PHP-8.4: soap: reject self-referential schema group and attributeGroup fix-up
* PHP-8.5: soap: reject self-referential schema group and attributeGroup fix-up
odbc_column_lengths() and odbc_field_type() ignored the SQLColAttribute return code and returned their output buffer regardless, so a driver that fails the call left odbc_field_len(), odbc_field_scale() and odbc_field_type() reporting uninitialized stack. Check the code, warn with the driver's own diagnostic, and return 0 or false instead. Closes GH-23601
* PHP-8.4: odbc: check SQLColAttribute return codes in the field info functions
* PHP-8.5: odbc: check SQLColAttribute return codes in the field info functions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )