[pull] master from php:master - #1254
Merged
Merged
Conversation
addChild() passed the caller's prefix to node_as_zval_str() with isprefix set to 0, so the returned element filtered its children by comparing that prefix against the namespace href and matched nothing. Take the prefix from the created node and mark it as one, but only when the caller asked for a namespace, so a plain addChild() keeps the unfiltered view that its attributes and non-namespaced children rely on. Closes GH-23599
* PHP-8.4: simplexml: fix addChild() namespace filter on the returned element
* PHP-8.5: simplexml: fix addChild() namespace filter on the returned element
#23612) odbc_colattribute_failed() existed only because odbc_sql_error() could not take a column number. Make the reporter variadic so callers can format the context into it, and route the two SQLColAttribute sites through it. Those failures now also populate the connection's last-error state, so odbc_error() and odbc_errormsg() report them. Closes GH-23612
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )