[pull] master from php:master - #1259
Merged
Merged
Conversation
…3594) php_iconv_stream_filter_seek() closed the filter's converter before knowing whether a replacement could be opened, then stored the failed iconv_open() result. That left self->cd as (iconv_t)-1 for every later read and write, and for the iconv_close() in the filter dtor. Open the replacement first and only swap it in on success. Closes GH-23594
php_dom_xpath_callbacks_get_gc() traced php_ns and namespaces but not node_list, which holds the nodes handed to and returned from php:function callbacks, so a cycle running DOMXPath to node_list to node and back was invisible to the collector. XSLTProcessor shares the registry and is affected whenever a transform does not reach its own node list cleanup, which a callback suspending a Fiber achieves. Reporting the list also makes it reachable while being torn down, so clean_node_list() detaches the table before destroying it; otherwise a node destructor calling gc_collect_cycles() has the collector read and write entries that zend_hash_destroy() already freed. Closes GH-23596
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )