[pull] master from ruby:master - #1402
Merged
Merged
Conversation
IO#input_pending? reports a pipe correctly there. 6600e7feed98 ruby/io-console@2598c88cec Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Extracted from `rb_str_chomp_string` and `rb_str_delete_suffix_bang`.
test_rehash mutates a key until its own `hash_hint` (the low byte of `Array#hash`) changes, then asserts the stale key no longer hits. Since 127e903 "hash.c: add a substition hint", `ar_do_hash_hint()` maps RHASH_AR_CLEARED_HINT (0x00) to RHASH_AR_SUBSTITUTION_HINT (0x01), so hash values ending in 0x00 and 0x01 share a hint. When the mutation loop happened to exit on such a pair, the test believed the hint had changed while the AR table's hint had not: `ar_find_entry_hint()` still matched and `ar_equal()` compared the key against itself, so the lookup returned 100 instead of nil. That commit adjusted the affected specs but not test/ruby/test_hash.rb. Mirror the substitution in `hash_hint` so the loop keeps going until the hint really changes. The hash seed is per process, so this depended on the run; measured over 2,000,000 independent starting hashes the old loop failed 63 times (1/31746), matching the predicted (2/256) * (1/255). Both TestHash and TestHash::TestSubHash fail together because they share a process and build the same strings. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )