[pull] master from ruby:master - #1418
Merged
Merged
Conversation
Previously we had a check that objects which were shareable, but not frozen on a non-main Ractor would raise an exception if instance variables were read. This prevented a non-main Ractor reading non-shareable objects. This changes the behaviour to forbid all writes to shareable objects (even when unfrozen). This is done by re-purposing the frozen flag on the object shape to reflect (FL_FROZEN || FL_SHAREABLE). With IV writes forbidden on all shareable objects whether or not they are frozen (with the exception of classes and modules), we can also remove the check against reading instance variables, since no unsafe instance variables can be set. [Bug #22291]
Move perf-map registration and symbol-range helpers into `perf`. Update the LIR backend and compiler callers to use the narrow module path. This separates optional instrumentation from the main lowering pipeline. It makes the perf dependency explicit without changing marker placement or normal code generation.
Array#values_at can execute arbitrary code during execution which may
modify the source array. This can cause a buffer overflow if the new length
of the array has decreased. The following script crashes:
a = (0..100_000).to_a
obj = Object.new
obj.define_singleton_method(:begin) do
a.clear
0
end
obj.define_singleton_method(:end) { 10_000 }
obj.define_singleton_method(:exclude_end?) { false }
puts a.values_at(obj).length
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )