Skip to content

fix(dev): wait for the final Postgres server over TCP (#2253) - #2254

Merged
cjimti merged 1 commit into
mainfrom
fix/2253-dev-postgres-ready
Oct 22, 2026
Merged

cjimti merged 1 commit into
mainfrom
fix/2253-dev-postgres-ready

Conversation

@cjimti

@cjimti cjimti commented Oct 22, 2026

Copy link
Copy Markdown
Member

Changes dev/start.sh's Postgres wait and the postgres healthcheck in dev/docker-compose.yml; one bug:

  1. On a fresh volume the Postgres image runs a temporary server for docker-entrypoint-initdb.d. It answers on the unix socket with the platform role and database already present. The wait connected over that socket, passed against the temporary server, and the auxiliary database check then reached it as it shut down ("the database system is shutting down"). That failed all ten acceptance jobs of the 2026-10-21 E2E Nightly (https://github.com/txn2/mcp-data-platform/actions/runs/39602596484) before any test ran, and the release candidate rules refused v1.149.0 on that nightly. The image starts the temporary server with listen_addresses='' (docker-entrypoint.sh), so the wait and the healthcheck now connect over TCP to 127.0.0.1, which only the final server answers.

Closes #2253

Changes dev/start.sh's Postgres wait and the postgres healthcheck in dev/docker-compose.yml; one bug:

1. On a fresh volume the image runs a temporary server for docker-entrypoint-initdb.d, which answers on the unix socket with the platform role and database already present. The wait connected over that socket, passed against the temporary server, and the auxiliary database check then hit it as it shut down ("the database system is shutting down"), which failed every job of the 2026-10-21 E2E Nightly before any test ran. The temporary server is started with listen_addresses='', so the wait and the healthcheck now connect over TCP to 127.0.0.1, which only the final server answers.

Closes #2253
@cjimti
cjimti merged commit 4390d6f into main Oct 22, 2026
7 checks passed
@cjimti
cjimti deleted the fix/2253-dev-postgres-ready branch October 22, 2026 07:27
@codecov

codecov Bot commented Oct 22, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.84%. Comparing base (b1def68) to head (3431326).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2254   +/-   ##
=======================================
  Coverage   94.84%   94.84%           
=======================================
  Files        1398     1398           
  Lines      113176   113176           
=======================================
+ Hits       107337   107338    +1     
+ Misses       5821     5820    -1     
  Partials       18       18           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

dev/start.sh treats the init-phase Postgres as ready; every nightly job failed

1 participant