Repository navigation
fix(dev): wait for the final Postgres server over TCP (#2253) - #2254
Merged
Merged
Conversation
Changes dev/start.sh's Postgres wait and the postgres healthcheck in dev/docker-compose.yml; one bug:
1. On a fresh volume the image runs a temporary server for docker-entrypoint-initdb.d, which answers on the unix socket with the platform role and database already present. The wait connected over that socket, passed against the temporary server, and the auxiliary database check then hit it as it shut down ("the database system is shutting down"), which failed every job of the 2026-10-21 E2E Nightly before any test ran. The temporary server is started with listen_addresses='', so the wait and the healthcheck now connect over TCP to 127.0.0.1, which only the final server answers.
Closes #2253
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2254 +/- ##
=======================================
Coverage 94.84% 94.84%
=======================================
Files 1398 1398
Lines 113176 113176
=======================================
+ Hits 107337 107338 +1
+ Misses 5821 5820 -1
Partials 18 18 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes dev/start.sh's Postgres wait and the postgres healthcheck in dev/docker-compose.yml; one bug:
Closes #2253