Repository navigation
Exit cleanly after test failures - #3
Merged
Merged
Conversation
everdance
approved these changes
Oct 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Failing
Runner.runWithArgsruns append an exception traceback after the test summary. Exit with status 1 using Python'ssys.exitand Ruby'sKernel.exitso the summary remains the final test report and normal runtime cleanup runs.Add subprocess regression checks for both failure fixtures: status 1, the expected assertion details and summary, matching backend reports, and no runner traceback. Run these checks through the existing output-checking CI step, replacing the shell check that required the old
tests failedexception message. Document the exit status in the README and record the fix under Unreleased inCHANGELOG.md.Add a PR template with a test and changelog checklist and a compatibility section.
Closes #2.
Check list
CHANGELOG.mdValidation passed: both runner conformance suites, output parity and clean-exit checks, and all three package builds.
git diff --checkpassed.Local validation used Jo 0.14.0, Python 3.10.12, and Ruby 3.0.2. CI targets Python 3.12 and Ruby 3.3.
Documentation changes were reviewed and checked with
git diff --check; the runtime checks above passed for the implementation commit.Compatibility
Public API signatures, package dependencies, and minimum runtime versions remain unchanged. Failed
Runner.runWithArgsruns still report status 1, with the final abort exception and traceback removed from their output. Callers that need to handle failure themselves can use the Boolean returned byRunner.run.