Skip to content

chore(deps): update dependency websockets to v17 - #263

Open
renovate[bot] wants to merge 3 commits into
mainfrom
renovate/websockets-17.x
Open

chore(deps): update dependency websockets to v17#263
renovate[bot] wants to merge 3 commits into
mainfrom
renovate/websockets-17.x

Conversation

@renovate

@renovate renovate Bot commented Jul 29, 2026

Copy link
Copy Markdown
Contributor

This PR contains the following updates:

Package Change Age Confidence
websockets (changelog) >=10, <16>=17, <18 age confidence

Release Notes

python-websockets/websockets (websockets)

v17.1

Compare Source

See https://websockets.readthedocs.io/en/stable/project/changelog.html for details.

v17.0.1

Compare Source

See https://websockets.readthedocs.io/en/stable/project/changelog.html for details.

v17.0

Compare Source

See https://websockets.readthedocs.io/en/stable/project/changelog.html for details.

v16.1.1

Compare Source

See https://websockets.readthedocs.io/en/stable/project/changelog.html for details.

v16.1

Compare Source

See https://websockets.readthedocs.io/en/stable/project/changelog.html for details.

v16.0

Compare Source

See https://websockets.readthedocs.io/en/stable/project/changelog.html for details.


Configuration

📅 Schedule: (UTC)

  • Branch creation
    • At any time (no schedule defined)
  • Automerge
    • At any time (no schedule defined)

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

@renovate

renovate Bot commented Jul 29, 2026

Copy link
Copy Markdown
Contributor Author

⚠️ Artifact update problem

Renovate failed to update an artifact related to this branch. You probably do not want to merge this PR as-is.

♻ Renovate will retry this branch, including artifacts, only when one of the following happens:

  • any of the package files in this branch needs updating, or
  • the branch becomes conflicted, or
  • you click the rebase/retry checkbox if found above, or
  • you rename this PR's title to start with "rebase!" to trigger it manually

The artifact failure details are included below:

File name: poetry.lock
Updating dependencies
Resolving dependencies...

Creating virtualenv rpcx-1CfOkIWv-py3.14 in /home/ubuntu/.cache/pypoetry/virtualenvs

The current project's supported Python range (>=3.10,<4.0) is not compatible with some of the required packages Python requirement:
  - websockets requires Python >=3.11, so it will not be satisfied for Python >=3.10,<3.11
  - websockets requires Python >=3.11, so it will not be satisfied for Python >=3.10,<3.11
  - websockets requires Python >=3.11, so it will not be satisfied for Python >=3.10,<3.11

Because no versions of websockets match >17,<17.0.1 || >17.0.1,<17.1 || >17.1,<18
 and websockets (17.0) requires Python >=3.11, websockets is forbidden.
And because websockets (17.0.1) requires Python >=3.11, websockets is forbidden.
So, because websockets (17.1) requires Python >=3.11
 and rpcx depends on websockets (>=17, <18), version solving failed.

  • Check your dependencies Python requirement: The Python requirement can be specified via the `python` or `markers` properties
    
    For websockets, a possible solution would be to set the `python` property to ">=3.11,<4.0"
    For websockets, a possible solution would be to set the `python` property to ">=3.11,<4.0"
    For websockets, a possible solution would be to set the `python` property to ">=3.11,<4.0"

    https://python-poetry.org/docs/dependency-specification/#python-restricted-dependencies,
    https://python-poetry.org/docs/dependency-specification/#using-environment-markers

@uSpike

uSpike commented Sep 3, 2026

Copy link
Copy Markdown
Owner

@copilot can you update the python requirement in pyproject.toml to ">=3.11,<4.0" and implement any require changes for websockets v17

Copilot AI commented Sep 3, 2026

Copy link
Copy Markdown

@copilot can you update the python requirement in pyproject.toml to ">=3.11,<4.0" and implement any require changes for websockets v17

Implemented in 0e851c4: Python support is now >=3.11,<4.0, the CI/tox/docs/tool targets are aligned, and the WebSocket wrapper now uses v17’s ClientConnection. The lockfile resolves WebSockets 17.1.

Copilot AI requested a review from uSpike September 3, 2026 15:33
@uSpike

uSpike commented Sep 3, 2026

Copy link
Copy Markdown
Owner

@copilot resolve the merge conflicts in this pull request

Copilot AI commented Sep 3, 2026

Copy link
Copy Markdown

@copilot resolve the merge conflicts in this pull request

Resolved in 182271f. The PR branch now includes the current main changes, with the Poetry lockfile conflict regenerated from the merged dependency constraints.

@renovate
renovate Bot force-pushed the renovate/websockets-17.x branch from 182271f to 04d4b43 Compare September 3, 2026 15:43
@uSpike

uSpike commented Sep 3, 2026

Copy link
Copy Markdown
Owner

@copilot fix problem with poetry.lock and pyproject out of sync

Co-authored-by: uSpike <5686650+uSpike@users.noreply.github.com>
@renovate

renovate Bot commented Sep 3, 2026

Copy link
Copy Markdown
Contributor Author

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

⚠️ Warning: custom changes will be lost.

Copilot AI commented Sep 3, 2026

Copy link
Copy Markdown

@copilot fix problem with poetry.lock and pyproject out of sync

Fixed in e8ca969. poetry.lock is regenerated with Poetry 1.8.5 and now resolves WebSockets 17.1 against the aligned Python 3.11+ manifest.

@uSpike
uSpike requested a review from vfazio September 3, 2026 16:09
@uSpike

uSpike commented Sep 3, 2026

Copy link
Copy Markdown
Owner

@vfazio look alright to you? not sure which python version you're locked to atm

@vfazio

vfazio commented Sep 3, 2026

Copy link
Copy Markdown
Collaborator

Most of the community has tried to remove upper-bound restrictions on the python interpreter in libraries because those restrictions end up flowing into downstream libraries and applications and becomes viral and a PITA to deal with.

Here's an old discussion: https://discuss.python.org/t/requires-python-upper-limits/12663

I collated some other relevant discussions in pydantic/pydantic#9663 which i will repost here


For some "light reading", see:

So, while our intention may be to cap the upper bounds, puzzle solvers may just fall back to an older version and install that since it was released without a cap, which may be undesired. It may also have unintended consequences for dependency lockfiles for certain package managers (like poetry).


The issue being you have a new version published that sets <3.15. When pip/poetry/etc go to solve what packages are installable for 3.15 they will scan back to older versions of the library that does not have the cap which is not likely to work any better than the current version but will give the clean installation will give the impression that everything is ok.

@uSpike

uSpike commented Sep 3, 2026

Copy link
Copy Markdown
Owner

@copilot change the supported python version to simple >=3.11 (or is it ^3.11) -- basically greater than or equal to python 3.11 and do not put an upper bounds on it.

Co-authored-by: uSpike <5686650+uSpike@users.noreply.github.com>

Copilot AI commented Sep 3, 2026

Copy link
Copy Markdown

@copilot change the supported python version to simple >=3.11 (or is it ^3.11) -- basically greater than or equal to python 3.11 and do not put an upper bounds on it.

Implemented in 997d010. The package requirement and lock metadata are now >=3.11 with no upper bound. The remaining <4.0 markers apply only to development dependencies whose own releases exclude Python 4, allowing Poetry to resolve the unbounded library requirement.

@uSpike

uSpike commented Sep 3, 2026

Copy link
Copy Markdown
Owner

Good now @vfazio ?

@vfazio

vfazio commented Sep 3, 2026

Copy link
Copy Markdown
Collaborator

Good now @vfazio ?

I'll have to think a bit harder on this...

The core library still works with 3.10 but the tests and examples will only work with 3.11 if we drop exceptiongroup and bump websockets. This is one of the "benefits" of having moved websockets out of the core so people can take whatever version works for their client.

The decision has to be made to:

  • change tox/CI to only test on 3.11+ with newer websockets
    or
  • minimally require 3.11 python for the entire library even if not necessary.

Python 3.10 goes EOL next month, so maybe it's ok to just drop it.

Either decision won't impact us because we're on 3.11 currently.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants