chore(deps): update dependency websockets to v17 - #263
Conversation
|
|
@copilot can you update the python requirement in pyproject.toml to ">=3.11,<4.0" and implement any require changes for websockets v17 |
Implemented in 0e851c4: Python support is now |
|
@copilot resolve the merge conflicts in this pull request |
182271f to
04d4b43
Compare
|
@copilot fix problem with poetry.lock and pyproject out of sync |
Co-authored-by: uSpike <5686650+uSpike@users.noreply.github.com>
Edited/Blocked NotificationRenovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR. You can manually request rebase by checking the rebase/retry box above. |
|
@vfazio look alright to you? not sure which python version you're locked to atm |
|
Most of the community has tried to remove upper-bound restrictions on the python interpreter in libraries because those restrictions end up flowing into downstream libraries and applications and becomes viral and a PITA to deal with. Here's an old discussion: https://discuss.python.org/t/requires-python-upper-limits/12663 I collated some other relevant discussions in pydantic/pydantic#9663 which i will repost here For some "light reading", see:
So, while our intention may be to cap the upper bounds, puzzle solvers may just fall back to an older version and install that since it was released without a cap, which may be undesired. It may also have unintended consequences for dependency lockfiles for certain package managers (like poetry). The issue being you have a new version published that sets <3.15. When pip/poetry/etc go to solve what packages are installable for 3.15 they will scan back to older versions of the library that does not have the cap which is not likely to work any better than the current version but will give the clean installation will give the impression that everything is ok. |
|
@copilot change the supported python version to simple >=3.11 (or is it ^3.11) -- basically greater than or equal to python 3.11 and do not put an upper bounds on it. |
Co-authored-by: uSpike <5686650+uSpike@users.noreply.github.com>
Implemented in 997d010. The package requirement and lock metadata are now |
|
Good now @vfazio ? |
I'll have to think a bit harder on this... The core library still works with 3.10 but the tests and examples will only work with 3.11 if we drop exceptiongroup and bump websockets. This is one of the "benefits" of having moved websockets out of the core so people can take whatever version works for their client. The decision has to be made to:
Python 3.10 goes EOL next month, so maybe it's ok to just drop it. Either decision won't impact us because we're on 3.11 currently. |
This PR contains the following updates:
>=10, <16→>=17, <18Release Notes
python-websockets/websockets (websockets)
v17.1Compare Source
See https://websockets.readthedocs.io/en/stable/project/changelog.html for details.
v17.0.1Compare Source
See https://websockets.readthedocs.io/en/stable/project/changelog.html for details.
v17.0Compare Source
See https://websockets.readthedocs.io/en/stable/project/changelog.html for details.
v16.1.1Compare Source
See https://websockets.readthedocs.io/en/stable/project/changelog.html for details.
v16.1Compare Source
See https://websockets.readthedocs.io/en/stable/project/changelog.html for details.
v16.0Compare Source
See https://websockets.readthedocs.io/en/stable/project/changelog.html for details.
Configuration
📅 Schedule: (UTC)
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR was generated by Mend Renovate. View the repository job log.