fix: exclude center-anchored topEdge/bottomEdge from Badge LEFT_PLACEMENTS - #5408
Merged
DianaSuvorova merged 2 commits intoSep 4, 2026
Merged
Conversation
…MENTS topEdge and bottomEdge are centered via `left: 50%` + `translateX(-50%)`, but they were also listed in LEFT_PLACEMENTS. Setting horizontalOffset on a badge with one of these placements overwrote `left: 50%` while leaving the translateX(-50%) in place, shifting the badge off-center instead of nudging it from its centered position. RIGHT_PLACEMENTS already excluded both, so this brings LEFT_PLACEMENTS in line with that.
…ffset Visually verifies that horizontalOffset no longer shifts center-anchored topEdge/bottomEdge badges off-center.
zigzagdev
requested review from
DianaSuvorova,
dyesin,
hualf1995 and
lijim
as code owners
September 3, 2026 13:32
|
|
Collaborator
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
topEdgeandbottomEdgeplacements are center-anchored (left: 50%+transform: translateX(-50%)), but they were also included inLEFT_PLACEMENTS.Setting
horizontalOffseton aBadgewith one of these placements overwroteleft: 50%while leavingtranslateX(-50%)in place, shifting the badge far off-center instead of nudging it from its centered position.RIGHT_PLACEMENTSalready excluded both, so this bringsLEFT_PLACEMENTSin line with it.PLACEMENT.topEdge/PLACEMENT.bottomEdgefromLEFT_PLACEMENTSinsrc/badge/styled components.tsbadge.scenario.tsxshowingtopEdge/bottomEdgewithhorizontalOffsetset, so the badge stays centeredScope
Patch: Bug Fix