Avoid duplicate parent.type lookup in dev-globals Babel plugin - #5409
Closed
MaddipatlaChetan24 wants to merge 1 commit into
Closed
Avoid duplicate parent.type lookup in dev-globals Babel plugin#5409MaddipatlaChetan24 wants to merge 1 commit into
MaddipatlaChetan24 wants to merge 1 commit into
Conversation
MaddipatlaChetan24
requested review from
DianaSuvorova,
dyesin,
hualf1995 and
lijim
as code owners
September 4, 2026 12:41
Collaborator
|
Not sure what is the value here. Will close |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1, Fixes #2
Description
Reads
path.parent.typeonce into a localparentTypevariable in theIdentifiervisitor, instead of accessing it twice via two separatepath.parent.type === '...'checks. Same nodes are skipped as before(
MemberExpressionandClassMethodparents); no behavioral change.Scope
Patch: Bug Fix