fix: ButtonGroup drops injected aria-checked/role via overrides.BaseButton - #5412
Open
zigzagdev wants to merge 2 commits into
Open
fix: ButtonGroup drops injected aria-checked/role via overrides.BaseButton#5412zigzagdev wants to merge 2 commits into
ButtonGroup drops injected aria-checked/role via overrides.BaseButton#5412zigzagdev wants to merge 2 commits into
Conversation
…seButton ButtonGroup spread `...child.props.overrides` after its own injected `overrides.BaseButton`, so a child that also set `overrides.BaseButton` (even for unrelated props like `style`) replaced the whole object and silently dropped the `aria-checked`/`role` ButtonGroup relies on for radio/checkbox semantics. Merge the child's BaseButton override on top of the injected one instead of replacing it wholesale.
Regression test for radio-mode ButtonGroup children that also pass overrides.BaseButton (e.g. for style) — aria-checked and role must still be set correctly.
zigzagdev
requested review from
DianaSuvorova,
dyesin,
hualf1995 and
lijim
as code owners
September 6, 2026 08:19
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1, Fixes #2Description
ButtonGroupinjectsaria-checked/roleonto each child viaoverrides.BaseButton, then spread...child.props.overridesafter it.If a child button also set
overrides.BaseButton(even just for an unrelated prop likestyle), the shallow spread replaced the wholeBaseButtonoverride object and silently dropped the injectedaria-checked/role, breaking radio/checkbox a11y semantics.Now, the child's
overrides.BaseButtonis merged on top of the injected one instead of replacing it wholesale, soaria checked/rolesurvive unless the child explicitly overrides them.Scope
Patch: Bug Fix