fix: prevent disabled Button rendered as an anchor from firing onClick - #5413
Open
zigzagdev wants to merge 2 commits into
Open
fix: prevent disabled Button rendered as an anchor from firing onClick#5413zigzagdev wants to merge 2 commits into
onClick#5413zigzagdev wants to merge 2 commits into
Conversation
internalOnClick only checked isLoading before invoking the user's onClick handler. A Button rendered as an <a href> with disabled set stays keyboard-operable (native <a> elements ignore the disabled attribute), so Tab + Enter still fired onClick and navigated. Guard on disabled the same way isLoading is guarded, preventing the default action and skipping the handler.
Regression test for a disabled Button rendered as <a href> — clicking it (which is how Tab + Enter activates an anchor) must not call the provided onClick handler.
zigzagdev
requested review from
DianaSuvorova,
dyesin,
hualf1995 and
lijim
as code owners
September 7, 2026 00:33
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
internalOnClickonly checkedisLoadingbefore invoking the user'sonClickhandler.When
Buttonis rendered as an<a href>(by passinghref) withdisabledset, it stays keyboard-operable — native<a>elements ignore thedisabledattribute entirely (unlike<button>), so Tab + Enter (or a click) still firedonClickand followed the link.Guard on
disabledthe same wayisLoadingis already guarded, preventing the default action and skipping the handler.Scope
Patch: Bug Fix