Fix #1034: Set default outcome learner and replace assertions with ValueErrors - #1039
Open
su-jin1425 wants to merge 1 commit into
Open
Fix #1034: Set default outcome learner and replace assertions with ValueErrors#1039su-jin1425 wants to merge 1 commit into
su-jin1425 wants to merge 1 commit into
Conversation
…lace assertions with ValueErrors
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Fixes #1034.
This PR updates
rlearner_scoreto use a defaultLGBMRegressorwhen an outcome learner is not provided. This allows users to callrlearner_scorewithXwithout having to manually provide an outcome learner.It also replaces input validation
assertstatements withValueErrorexceptions in the CATE scoring functions. This ensures validation errors are raised consistently, including when Python is run with optimization enabled.Before
After
Test
Before
After
Changes
outcome_learnerinrlearner_scoretoLGBMRegressor.assertstatements withValueErrorchecks in:dr_scoreplug_in_t_scorerlearner_scoreTypes of changes
Checklist
Further comments
The previous implementation used
assertfor user input validation. Since assertions can be disabled with Python's-Ooption, these checks were changed to explicitValueErrorexceptions.The
rlearner_scorechange also provides a default outcome learner so that the documented usage withXworks without requiring users to explicitly construct and pass an outcome learner.