#1035: Fix meta-learner random_state handling with check_random_state - #1040
Open
su-jin1425 wants to merge 1 commit into
Open
#1035: Fix meta-learner random_state handling with check_random_state#1040su-jin1425 wants to merge 1 commit into
su-jin1425 wants to merge 1 commit into
Conversation
…heck_random_state
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Fixes #1035.
This change normalizes
random_statehandling in the meta-learner bootstrap paths using scikit-learn'scheck_random_state.Specifically:
np.random.RandomState(...)construction withcheck_random_state(...).RandomStateinstances to be passed without raising aTypeError.The change is limited to the existing random-state handling and does not change the public API behavior for existing integer seeds.
Types of changes
Checklist
Further comments
The reported issue was reproduced on the parent commit: passing a
RandomStateinstance tonp.random.RandomState(...)raises aTypeError.The same input was verified successfully on this commit using
check_random_state(...).The full test suite could not be run locally because the Windows environment blocked a Cython DLL during dependency installation.