#1036: Fix S- and X-learner bootstrap confidence interval reproducibility - #1041
Open
su-jin1425 wants to merge 1 commit into
Open
#1036: Fix S- and X-learner bootstrap confidence interval reproducibility#1041su-jin1425 wants to merge 1 commit into
su-jin1425 wants to merge 1 commit into
Conversation
…p CIs reproducible
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Fixes #1036.
S- and X-learner bootstrap confidence intervals were using the global NumPy random state, making results change when unrelated code consumed the global RNG.
This change:
random_statesupport to the affected S- and X-learner classes.check_random_state.random_stateis preserved throughget_params()andclone().The existing T-learner seeded bootstrap path and DR-learner behavior are preserved.
Before and After
Test
Types of changes
Checklist
Further comments
The fix uses the existing
check_random_stateapproach established by #1035 and keeps the change limited to bootstrap random-state handling and its regression coverage.