Fix oversized LightGBM default for CATE scoring #1037 - #1042
Open
su-jin1425 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Reduce the default
num_leavesfor the LightGBM learners used by CATE scoring from 64 to 31.These learners are fit per fold and per treatment arm, so the previous default was unnecessarily large for the smaller training subsets and could result in unnecessary computation.
This updates the defaults in:
compute_dr_pseudo_outcomesdr_scoreplug_in_t_scoreAlso adds/strengthens tests covering the default learner paths.
Fixes #1037.
Before and After
Test
Types of changes
Checklist
Further comments
The change keeps the existing LightGBM learner configuration unchanged apart from
num_leaves, reducing the model size for the per-fold, per-arm fitting pattern without changing the public API.