Remove CAV5 in favour of quantile indexed xarray #240

Activity

1. lispandfound

   added

   enhancementNew feature or requestNew feature or request

   ai-okVetted: the bot may attempt a fixVetted: the bot may attempt a fix

   on Sep 29, 2026
2. ucgmsim commented on Oct 3, 2026

   

   ucgmsimBot

   on Oct 3, 2026

   Contributor

   More actions

   The scheduled fix job gave up on this issue:

   Skipping issue #240: this is a feature/refactor request, not a bug fix.

   The issue ("Remove CAV5 in favour of quantile indexed xarray") explicitly
   asks for a design change to the CAV intensity measure API:

   1. Remove the CAV5 entry from the IM enum.
   2. Change cumulative_absolute_velocity to accept an array of thresholds
      and return a result with a new threshold dimension/coordinate (like
      pseudo_spectral_acceleration does for period).
   3. Reimplement the current scalar-threshold CAV/CAV5 behaviour as thin
      wrappers over the new array-threshold implementation, squeezing the
      threshold dimension into an attribute.

   There is no described defect, incorrect output, or failing behaviour in the
   current CAV/CAV5 code — _cav_kernel/cumulative_absolute_velocity in
   IM/ims.py compute CAV and thresholded CAV5 correctly, and the existing tests
   (tests/test_ims.py::test_cav5, test_cav_name_depends_on_threshold) pass and
   describe the intended, correct output. The issue itself says "This will
   require a follow-up PR on workflow to incorporate the change," confirming
   it is a deliberate multi-PR API/data-model change rather than a bug report.

   Per the task instructions, this falls under "the issue asks for anything
   other than a bug fix," so no code changes were made. A reviewer who wants
   this feature should scope it as a planned refactor (enum change + public
   API/return-shape change across IM/ims.py, IM/im_calculation.py,
   IM/scripts/calculate_ims.py, and the dependent workflow repo), not a
   regression-test-driven bug fix.

   Remove ai-stuck and re-add ai-ok to retry.
3. ucgmsim

   added

   ai-stuckThe bot tried and gave up; see its commentThe bot tried and gave up; see its comment

   and removed

   ai-okVetted: the bot may attempt a fixVetted: the bot may attempt a fix

   on Oct 3, 2026