Repository navigation
Fix wiki deploy branch and pin PyPI publish action to a tag - #248
Merged
Merged
Conversation
## Summary The repo already matches most of the shared CI baseline. `ci.yml` calls `ucgmsim/meta-ci-action/.github/workflows/ci.yml@v2` on `pull_request` and on `push` to `master`, with coverage at 95. `claude-review.yml` is a thin `issue_comment` wrapper around the shared workflow, and `lefthook.yml` loads the shared `lefthook/ci.yml` remote at `v2`. The only local hook is a `yaml` (yamllint) command, which isn't one of the shared commands. `[tool.npdlint]` already sets `include = ["IM"]`. This PR fixes the two places where the repo still doesn't match: - **`wiki.yml`**: the push trigger listed `branches: "main"`, but this repo's default branch is `master`. Because of that, the wiki deploy never ran on push. It now uses `branches: [master]`. - **`publish-PyPI.yml`**: `pypa/gh-action-pypi-publish@release/v1` pointed at a branch. The baseline says third-party actions must not be pinned to a branch, so it now uses the release tag `v1.13.0`. No new checks were added, because every check the shared CI offers was already running. `.ai/ci-checks` passed before these changes, and this PR only touches workflow YAML. ## Might still go red - I haven't run the publish workflow with the `v1.13.0` tag. It only runs on release, so the next release is the first real test. - `dtolnay/rust-toolchain@stable` still points at a branch. That is how the action is meant to be used: the branch name picks the toolchain. meta-ci-action's own `ci.yml` uses it the same way, so I left it alone. _Cost $0.23, 14 turns._ 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
lispandfound
approved these changes
Oct 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The repo already matches most of the shared CI baseline.
ci.ymlcallsucgmsim/meta-ci-action/.github/workflows/ci.yml@v2onpull_requestand onpushtomaster, with coverage at 95.claude-review.ymlis a thinissue_commentwrapper around the shared workflow, andlefthook.ymlloads the sharedlefthook/ci.ymlremote atv2. The only local hook is ayaml(yamllint) command, which isn't one of the shared commands.[tool.npdlint]already setsinclude = ["IM"].This PR fixes the two places where the repo still doesn't match:
wiki.yml: the push trigger listedbranches: "main", but this repo's default branch ismaster. Because of that, the wiki deploy never ran on push. It now usesbranches: [master].publish-PyPI.yml:pypa/gh-action-pypi-publish@release/v1pointed at a branch. The baseline says third-party actions must not be pinned to a branch, so it now uses the release tagv1.13.0.No new checks were added, because every check the shared CI offers was already running.
.ai/ci-checkspassed before these changes, and this PR only touches workflow YAML.Might still go red
v1.13.0tag. It only runs on release, so the next release is the first real test.dtolnay/rust-toolchain@stablestill points at a branch. That is how the action is meant to be used: the branch name picks the toolchain. meta-ci-action's ownci.ymluses it the same way, so I left it alone.Cost $0.23, 14 turns.
🤖 Generated with Claude Code