Skip to content

Fix wiki deploy branch and pin PyPI publish action to a tag - #248

Merged
lispandfound merged 1 commit into
masterfrom
ai/ci
Oct 4, 2026
Merged

lispandfound merged 1 commit into
masterfrom
ai/ci

Conversation

@ucgmsim

@ucgmsim ucgmsim Bot commented Oct 4, 2026

Copy link
Copy Markdown
Contributor

Summary

The repo already matches most of the shared CI baseline. ci.yml calls ucgmsim/meta-ci-action/.github/workflows/ci.yml@v2 on pull_request and on push to master, with coverage at 95. claude-review.yml is a thin issue_comment wrapper around the shared workflow, and lefthook.yml loads the shared lefthook/ci.yml remote at v2. The only local hook is a yaml (yamllint) command, which isn't one of the shared commands. [tool.npdlint] already sets include = ["IM"].

This PR fixes the two places where the repo still doesn't match:

  • wiki.yml: the push trigger listed branches: "main", but this repo's default branch is master. Because of that, the wiki deploy never ran on push. It now uses branches: [master].
  • publish-PyPI.yml: pypa/gh-action-pypi-publish@release/v1 pointed at a branch. The baseline says third-party actions must not be pinned to a branch, so it now uses the release tag v1.13.0.

No new checks were added, because every check the shared CI offers was already running. .ai/ci-checks passed before these changes, and this PR only touches workflow YAML.

Might still go red

  • I haven't run the publish workflow with the v1.13.0 tag. It only runs on release, so the next release is the first real test.
  • dtolnay/rust-toolchain@stable still points at a branch. That is how the action is meant to be used: the branch name picks the toolchain. meta-ci-action's own ci.yml uses it the same way, so I left it alone.

Cost $0.23, 14 turns.

🤖 Generated with Claude Code

## Summary

The repo already matches most of the shared CI baseline. `ci.yml` calls `ucgmsim/meta-ci-action/.github/workflows/ci.yml@v2` on `pull_request` and on `push` to `master`, with coverage at 95. `claude-review.yml` is a thin `issue_comment` wrapper around the shared workflow, and `lefthook.yml` loads the shared `lefthook/ci.yml` remote at `v2`. The only local hook is a `yaml` (yamllint) command, which isn't one of the shared commands. `[tool.npdlint]` already sets `include = ["IM"]`.

This PR fixes the two places where the repo still doesn't match:

- **`wiki.yml`**: the push trigger listed `branches: "main"`, but this repo's default branch is `master`. Because of that, the wiki deploy never ran on push. It now uses `branches: [master]`.
- **`publish-PyPI.yml`**: `pypa/gh-action-pypi-publish@release/v1` pointed at a branch. The baseline says third-party actions must not be pinned to a branch, so it now uses the release tag `v1.13.0`.

No new checks were added, because every check the shared CI offers was already running. `.ai/ci-checks` passed before these changes, and this PR only touches workflow YAML.

## Might still go red

- I haven't run the publish workflow with the `v1.13.0` tag. It only runs on release, so the next release is the first real test.
- `dtolnay/rust-toolchain@stable` still points at a branch. That is how the action is meant to be used: the branch name picks the toolchain. meta-ci-action's own `ci.yml` uses it the same way, so I left it alone.

_Cost $0.23, 14 turns._

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
@ucgmsim ucgmsim Bot added ai-generated Opened by the scheduled Claude jobs ai-ci Bot-written CI change that needs review labels Oct 4, 2026
@ucgmsim
ucgmsim Bot requested a review from lispandfound October 4, 2026 22:03
@lispandfound
lispandfound merged commit dfce035 into master Oct 4, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ai-ci Bot-written CI change that needs review ai-generated Opened by the scheduled Claude jobs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant