Repository navigation
Read only old schema versions - #6
Merged
Merged
Conversation
lispandfound
approved these changes
Sep 21, 2026
lispandfound
left a comment
lispandfound
left a comment
Contributor
There was a problem hiding this comment.
Seems good to me, only one suggestion about one of the comments which you can ignore.
Co-authored-by: Jake Faulkner <jakefaulkn@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Lets the current codebase open an older-schema IMDB read-only, instead of rejecting any schema_version mismatch outright.
Compatible versions are tracked explicitly in schema.READ_COMPATIBLE_SCHEMA_VERSIONS, a manually maintained set, not a range check, so future schema bumps can be added once their read path is confirmed unaffected. Write access (read_only=False) still requires an exact SCHEMA_VERSION match, this change only relaxes the read path.
Manually verified against 2 real older schema databases that all get_* methods return correct data under the new code.
Added tests covering: