Repository navigation
fix: keep heatmap overlay composited above the iframe snapshot in Safari - #4631
Open
CloudCorpRecords wants to merge 1 commit into
Open
CloudCorpRecords wants to merge 1 commit into
CloudCorpRecords wants to merge 1 commit into
Conversation
|
@CloudCorpRecords is attempting to deploy a commit to the Umami Software Team on Vercel. A member of the Team first needs to authorize it. |
Contributor
[Medium impact] The PR appears safe to merge; no actionable regression was found. SummaryKeeps the heatmap overlay above the iframe snapshot while scrolling in Safari.
No actionable issues found. CloudCorpRecords states that the original bug requires real Safari GPU rendering and does not reproduce in Playwright WebKit. Real Safari behavior was not verified during this review. Reviews (1) · Last reviewed commit: "fix: keep heatmap overlay composited abo..." · Reviewed by Greptile |
Closes umami-software#4624. Signed-off-by: Rene Turcios <95189389+CloudCorpRecords@users.noreply.github.com>
CloudCorpRecords
force-pushed
the
fix/issue-4624-heatmap-safari
branch
from
October 19, 2026 14:58
4364c94 to
af786be
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4624.
In Safari, the heatmap click dots disappeared while scrolling because the iframe snapshot painted over the overlay.
The overlay is now promoted to its own compositing layer (translateZ(0) plus will-change), .snapshotClip gets isolation: isolate with z-index 0, and the scroll view's SnapshotPreview is wrapped in .snapshotClip for parity with the main view.
Note: as the reporter found, this does not reproduce in Playwright WebKit (it needs real Safari GPU compositing), so this fix is by code inspection of the compositing and stacking behavior.
Need help on this PR? Tag
@codesmith-botwith what you need.