Repository navigation
Conversation
|
@xlb3055 is attempting to deploy a commit to the Umami Software Team on Vercel. A member of the Team first needs to authorize it. |
Contributor
[Low impact] The PR appears safe to merge; no actionable issues were found. SummaryFixes Galician date formatting without changing saved language preferences.
Review checks were limited to source inspection; tests and the application were not run. Reviews (1) · Last reviewed commit: "fix(i18n): use Galician locale for dates" · Reviewed by Greptile |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Selecting Galician currently formats dates in Spanish because its
dateLocalepoints toes. For example, formatting 1 January 2024 withEEEE, d MMMM yyyyproduceslunes, 1 enero 2024instead ofluns, 1 xaneiro 2024.Use date-fns' existing
gllocale and add a regression test covering actual weekday and month output. Also correct the language's display label to "Galician". Keep the existingga-ESsettings key so saved language preferences remain compatible.This was found while inspecting the locale mappings; there is no separate bug report. The original Galician translation was requested in #1215.
Validation
src/lib/lang.test.ts: all 7 tests passed with Vitest 5.0.3 and date-fns 4.4.0 (the lockfile versions), run under a minimal Node-only config instead of the app's DOM setup. The new test fails with the Spanish output before the fix.npm run lint: the 6 errors it reports are in unchanged files (the not-found page and SVG assets).git diff --check: passed.Not run: the full application build and database-backed tests (no local database, limited disk space).
AI assistance was used to investigate and implement this change; the checks above were run locally.
🤖 Generated with Claude Code
Need help on this PR? Tag
@codesmith-botwith what you need.