Skip to content

fix(i18n): use Galician locale for dates - #4643

Open
xlb3055 wants to merge 1 commit into
umami-software:devfrom
xlb3055:fix/galician-date-locale
Open

xlb3055 wants to merge 1 commit into
umami-software:devfrom
xlb3055:fix/galician-date-locale

Conversation

@xlb3055

@xlb3055 xlb3055 commented Oct 19, 2026 •

Copy link
Copy Markdown

Summary

Selecting Galician currently formats dates in Spanish because its dateLocale points to es. For example, formatting 1 January 2024 with EEEE, d MMMM yyyy produces lunes, 1 enero 2024 instead of luns, 1 xaneiro 2024.

Use date-fns' existing gl locale and add a regression test covering actual weekday and month output. Also correct the language's display label to "Galician". Keep the existing ga-ES settings key so saved language preferences remain compatible.

This was found while inspecting the locale mappings; there is no separate bug report. The original Galician translation was requested in #1215.

Validation

  • src/lib/lang.test.ts: all 7 tests passed with Vitest 5.0.3 and date-fns 4.4.0 (the lockfile versions), run under a minimal Node-only config instead of the app's DOM setup. The new test fails with the Spanish output before the fix.
  • Biome check on both changed files: passed.
  • npm run lint: the 6 errors it reports are in unchanged files (the not-found page and SVG assets).
  • git diff --check: passed.

Not run: the full application build and database-backed tests (no local database, limited disk space).

AI assistance was used to investigate and implement this change; the checks above were run locally.

🤖 Generated with Claude Code


View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need.

@vercel

vercel Bot commented Oct 19, 2026

Copy link
Copy Markdown

@xlb3055 is attempting to deploy a commit to the Umami Software Team on Vercel.

A member of the Team first needs to authorize it.

@greptile-apps

greptile-apps Bot commented Oct 19, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerView in GreptileConfidence Score: 5/5

[Low impact] The PR appears safe to merge; no actionable issues were found.

Summary

Fixes Galician date formatting without changing saved language preferences.

  • Galician dates use Galician names, and the language label reads “Galician (Spain)”.

Review checks were limited to source inspection; tests and the application were not run.

Reviews (1) · Last reviewed commit: "fix(i18n): use Galician locale for dates" · Reviewed by Greptile

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant