Repository navigation
Refine accepts a board of phone screens side by side at 1280 - #111
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two rules found
src/render-check.mjs:671: anydata-oc-screenat 1280 that is ≤390px wide fails with "Let each outer screen use the desktop width…", which ends refine in MAKE_FAILED (src/cli.mjs:506). Its prompt twin issrc/make.mjs:45("never use different screens as desktop grid columns").src/critic.mjsandsrc/redesign-check.mjshold no width dock; the critic is a model judge with no phone-width rule. The only code that rejects the wide layout is the line-671 check, so I found one deterministic rule, not two.Pick
Let the refinement keep phone frames on a desktop board: a board of phone screens reviewed at 1280 is a real pattern. Line 671 now skips when the whole page lays two or more ≤390px screens in one row; a lone phone canvas stretched on desktop is still refused. The make.mjs sentence gets a matching exception so the model is not told the opposite.
Proof
Nonpaid journey
journeys/phone-board.mjs, output in/home/umer/.treehouse/firstmate-cff959/3/firstmate/data/refine-refuses-phone-width-screens-at-12-7a/after(before = same journey on main's render check,/home/umer/.treehouse/firstmate-cff959/3/firstmate/data/refine-refuses-phone-width-screens-at-12-7a/before): the 3-phone 1280 board has no phone-sized finding (board-3-phones.errors.json); the lone phone is still refused. The old check refused the board.proof: no verify skill (
done-done-verify-first-drafthas no feature for this); commandnode journeys/phone-board.mjs <evidence-dir>.Not shown: a live model judge scoring the board, since the critic has no width rule to run.
Checks
outcome: A design board that lays three 390px phone screens side by side at 1280 wide passes the render check instead of ending refine with MAKE_FAILED, while a lone phone canvas stretched on a desktop board is still refused.
repro: n/a
proof: no verify skill (done-done-verify-first-draft has no feature for this); done-done run 20261030T122028Z-f9580ad0-fb1aa0 at head f9580ad
evidence: 20261030T122028Z-f9580ad0-fb1aa0/board-3-phones.errors.json, 20261030T122028Z-f9580ad0-fb1aa0/lone-phone.errors.json, 20261030T122028Z-f9580ad0-fb1aa0/summary.json
screen: none