Repository navigation
ci(evidence): retain phase timing and live progress - #72
Draft
undergroundrap wants to merge 20 commits into
Draft
undergroundrap wants to merge 20 commits into
undergroundrap wants to merge 20 commits into
Conversation
Retain phase-timing observability and live progress reporting in CI evidence capture. Wraps Full-tier checks in Invoke-HumPhase timing markers; live progress observer reports phase start while capture is active via owned synthetic fixtures. Review: Codex r6 ACCEPTED with zero findings (2026-10-11), first CI observability deliverable under the existing repair authority. All five production files frozen through r1-r6 review; only the test fixture changed between rounds. Selected Test 10: 34/34 assertions across 12 actual-loop executions, zero real accessors. Base: 6b8b4d5 Candidate: oupa-outbox/hum-ci-live-phase-progress-20261010T055207662199Z-r6/ Fixture: 5dddb0d (59977 bytes) Note: test_ci_policy.ps1's 'Full consumes shared' regex predates the Invoke-HumPhase wrapper and does not match the wrapped invocations; all six shared check functions remain invoked (verified), no omissions. Policy test update is out of scope for this candidate.
The function-seal mutation recipe in test_fast_evidence_capture.ps1 built one concatenated string instead of four distinct inputs: PowerShell's array comma binds looser than + inside @(), so the removal/duplication/nesting/rename sources concatenated into a single 2,980,329-char blob carrying 3 InvalidLeftHandSide parse errors. Get-DiscoveryAst rejected it and PR #72 preflight failed on both platforms in run 38109728483. Parenthesize each element so @() constructs four distinct complete source strings, and add fatal guards immediately after construction: count must be exactly 4, each input non-empty, SHA256 hashes distinct. Review: Codex ACCEPT (r1 implementation + r2 receipt, 2026-10-11). Independent static-owner proof: 4 distinct inputs parse 0, all rejected by unchanged Assert-FirstPwshOwner; original source passes. All six R6 production files unchanged. Parent: 21f2c4b Fixture: f9f22be (155404 bytes)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Retain phase-timing observability and live progress reporting in CI evidence capture.
Review: Codex r6 ACCEPTED with zero findings (2026-10-11) — first CI observability deliverable under the existing repair authority. All five production files frozen through r1–r6 review; only the test fixture changed between rounds.
Evidence (selected, per review scope):
Scope note:
test_ci_policy.ps1's "Full consumes shared" regex predates theInvoke-HumPhasetiming wrapper and does not match the wrapped invocations. All six shared check functions remain invoked (verified 8/3/2/3/4/3), no omissions. Policy test update is out of scope for this candidate.Draft until required Full CI is green on the exact head
21f2c4b8.