Feat/information form#103
Open
Suboyyy wants to merge 35 commits into
Open
Conversation
Suboyyy
marked this pull request as ready for review
July 18, 2026 18:00
tuturd
reviewed
Jul 21, 2026
| fetchOnboardingStatus(); | ||
| }, []); | ||
|
|
||
| const fetchOnboardingStatus = async () => { |
Member
There was a problem hiding this comment.
Il faut faire un composant <OnboardNeeded type="Nouveau"> par exemple pour filtrer l'affichage des différents composants, bien plus lisible selon moi que le code dupliqué sur chaque composant.
On peut lui fournir du texte pour les messages d'erreurs du type "billetterie soirée d'intégration" à ajouter après les messages d'erreur.
Member
Author
There was a problem hiding this comment.
J'ai pas compris ce que tu voulais exactement
| fetchOnboardingStatus(); | ||
| }, []); | ||
|
|
||
| const fetchOnboardingStatus = async () => { |
| setMenuOpen(false); | ||
| }, [pathname]); | ||
|
|
||
| const fetchOnboardingStatus = async () => { |
Member
There was a problem hiding this comment.
peut être passer par un statut global pour éviter les requêtes multiples sur le statut onboarding (autre PR selon moi)
Co-authored-by: Arthur Dodin <52950784+tuturd@users.noreply.github.com>
Co-authored-by: Arthur Dodin <52950784+tuturd@users.noreply.github.com>
Co-authored-by: Arthur Dodin <52950784+tuturd@users.noreply.github.com>
Remi-pcn
reviewed
Jul 22, 2026
Remi-pcn
left a comment
Remi-pcn
left a comment
Contributor
There was a problem hiding this comment.
A part les 2/3 points notés par arthur le reste peut attendre pour etre modifie. Sinon lgtm j'ai pas vu de dinguerie
| @@ -0,0 +1,4 @@ | |||
| export type UserContactInformation = { | |||
| urgency_contact_name: string; | |||
| urgency_contact_phone: string; | |||
Contributor
There was a problem hiding this comment.
Pareil qu'avant ducoup, plutot "emergency"
Member
Author
|
Si on est pas sur la page d'accueil le modal s'affiche pas... |
Member
Après la session de test n°1To: @Suboyyy Caution Problèmes identifiés nécessitants un patch avant merge Problèmes identifiés
Améliorations à prévoir
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.