Enhancement/128 add facade layer to room - #133
Open
PIPetkova19 wants to merge 16 commits into
Open
Conversation
Manastirski
previously approved these changes
Jul 24, 2026
deviserbg
reviewed
Jul 29, 2026
| private final RoomMapper roomMapper; | ||
| private final RoomService roomService; | ||
|
|
||
| private Room getRoomOrThrow(final UUID id) { |
Contributor
There was a problem hiding this comment.
Why this method is called getRoomOrThrow?
The idea of exception is that they happen unexpectedly there is no need to add that behavior in the method name.
Contributor
Author
There was a problem hiding this comment.
I was following the same naming convention that's already used in the other files. We can open another pr to refactor the naming across all the files?
| private Room entity; | ||
| private RoomResponseDto responseDto; | ||
| private UUID id; | ||
| private UUID categoryId; |
constantine0621
left a comment
constantine0621
left a comment
Contributor
There was a problem hiding this comment.
RoomValidator missing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes made:
BaseServiceinterface.