Repository navigation
Render markdown documents in the Workspace Rendered view - #396
Open
coolestnick wants to merge 1 commit into
Open
coolestnick wants to merge 1 commit into
coolestnick wants to merge 1 commit into
Conversation
Opening a .md file in the Workspace (or the standalone artifact editor) showed the raw source in the Rendered view: literal "##", backticks and list markers instead of formatted headings, code and lists. A markdown file is a text document, which fell straight through to the plain source textarea in both views, so Rendered and Code looked the same. Markdown documents now render properly: the Rendered view shows the formatted document using the same renderer the conversation uses, and the Code view holds the editable raw source, so the text stays editable. Other text documents are unchanged. The markdown surfaces are split into a small new file so the shared surface switcher stays under its size cap (its baseline is tightened to match). A test covers the markdown detection and that Rendered formats while Code stays an editable source.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #398
Opening a .md file in the Workspace (or the standalone artifact editor) showed the raw source in the Rendered view: literal "##", backticks and list markers instead of formatted headings, code and lists. A markdown file is a text document, which fell straight through to the plain source textarea in both views, so Rendered and Code looked the same.
Markdown documents now render properly: the Rendered view shows the formatted document using the same renderer the conversation uses, and the Code view holds the editable raw source, so the text stays editable. Other text documents are unchanged.
The markdown surfaces are split into a small new file so the shared surface switcher stays under its size cap (its baseline is tightened to match). A test covers the markdown detection and that Rendered formats while Code stays an editable source.
Screenshots
|
| 
|
By opening this pull request you agree to the Contributor License Agreement. On your first pull request a bot asks you to sign it with a one-line comment.
Need help on this PR? Tag
@codesmith-botwith what you need.