chore(scan): answer the hol plugin scanner findings - #649
Merged
Merged
Conversation
The secret fixtures the scanner matched are assembled at run time; the marketplace build declares strict at the manifest's root (where the scanner reads it) and on every entry (where Claude Code does), and carries LICENSE and SECURITY.md into the plugin directory. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
tests/skills/odd-memory/test_odd_report.py: the three fixture values the HOL scanner's secret patterns matched (HARDCODED_SECRET, high) are assembled at run time; the strings, and the test, are unchanged.scripts/build-marketplace.sh: declares"strict": truein.claude-plugin/marketplace.jsonat the root and on every entry, and copiesLICENSEandSECURITY.mdintomarketplace/oddyssey/. The generated trees are not in this PR: the next release regenerates and commits them.Why
plugin-scanner 3.0.123 (hashgraph-online/awesome-ai-plugins#410) fails the job on any
highand reports three lower findings. It readsstrictonly at the manifest's root, Claude Code only per entry: both are declared (amendment recorded on the issue).How to test
uvx --from plugin-scanner==3.0.123 plugin-scanner scan .: 95/100, the one finding left is the untracked, ignoreddocker-compose/llms-benchmark/.env, out of scope.claude plugin validate .passes (a warning on the rootstrict); Claude Code 2.1.280 and Copilot CLI 1.0.88 add the rebuilt local marketplace and install the plugin.tests/skillsandtests/hookspass.Review
A separate reviewer sub-agent found one blocking issue: the strict step chained
jq … && cp …, so underset -ea jq failure was skipped silently and the release would have committed a manifest withoutstrict. Split into two statements; the same reviewer then reported nothing left to fix.Closes #648
🤖 Generated with Claude Code