Release v1.6.0 - #753
Merged
Merged
Release v1.6.0#753
Conversation
Cache X3 USB power state for one second in the main loop, avoiding repeated BQ27220 I2C reads while preserving direct startup and render-time probes. Adapted from Sichroteph/YACP under the MIT license. Adapted-from: Sichroteph/YACP@6d1f10f Co-authored-by: Totofaki <Christophe.Jeannette@gmail.com>
Load Recent Books and KOReader credentials on first use, skip the unchanged recents update on direct sleep resumes, and avoid no-op recent-book writes. Adapted from Sichroteph/YACP under the MIT license, while preserving CrossInk cover-state metadata and network-resume behavior. Adapted-from: Sichroteph/YACP@20af8ae Co-authored-by: Totofaki <Christophe.Jeannette@gmail.com>
Compare an existing daily backup in a fixed 64-byte buffer and avoid replacing it when the current stats file is identical. Adapted from Sichroteph/YACP under the MIT license. Adapted-from: Sichroteph/YACP@20af8ae Co-authored-by: Totofaki <Christophe.Jeannette@gmail.com>
…#3355) ## Summary * **What is the goal of this PR?** * Restore CSS superscript and subscript styling on internal EPUB links, including the footnote markers commonly written as `<a style="vertical-align: super">1</a>`. * **What changes are included?** * Apply resolved `vertical-align: super/sub` styles when parsing internal link elements, matching the existing generic inline-style behavior. * Bump `section.bin` to version 45 so cached layouts created before the fix are automatically rebuilt. * Add a generated EPUB fixture plus focused host tests covering both superscript and subscript internal links. The tests verify the text style and retained link target/ID. ## Additional Context * The regression was limited to the parser’s internal-link branch: it preserved the link and underline but returned before applying `vertical-align`.
…er#3126) Co-authored-by: Uri Tauber <uritaube@gmail.com>
…rosspoint-reader#3364) ## Summary * **What is the goal of this PR?** Make two settings-screen lookup tables' compile-time/flash placement standard-guaranteed instead of compiler-observed, per this repo's "`constexpr` First" coding standard (CLAUDE.md rule #6). * **What changes are included?** - `SettingsActivity::categoryNames` and `OpdsServerListActivity`'s `formatLabels` converted from `static const` to `static constexpr` - Removed the now-unnecessary out-of-line `.cpp` definition for `categoryNames` (replaced by an inline `constexpr` initializer in the header) ## Scope Check CrossPoint is intentionally narrow. See [SCOPE.md](../blob/master/SCOPE.md) and [ROADMAP.md](../blob/master/ROADMAP.md). Please confirm: - [x] I have read SCOPE.md and ROADMAP.md. - [x] This PR is **not** a new built-in theme (themes are temporarily closed pending the move to SD-loaded themes). - [x] This PR is **not** a new external network connector (sync engine, cloud storage, remote file access, etc.). - [x] This PR is **not** an interactive app, writing tool, RSS/news/browser, media playback, or PDF feature. - [x] The stock firmware does not already handle this well, **and** no other popular CrossPoint fork already does (n/a — this is an internal code-quality refactor, not a user-facing feature). - [x] If this PR touches `freeink-sdk/`, `lib/hal/`, the bootloader, OTA, or recovery code, I have coordinated with the relevant maintainer. (n/a — this PR only touches `src/activities/settings/`.) ## Additional Context * No behavior, control flow, or memory layout change. `static const` already landed in flash in practice on this toolchain; `constexpr` makes that guaranteed by the standard instead of compiler-observed, and enables compile-time evaluation for these two small (12-byte and 16-byte) literal `StrId` tables. * Verified via `pio run` (build succeeds) and `pio check` (cppcheck: no defects found). --- ### AI Usage While CrossPoint doesn't have restrictions on AI tools in contributing, please be transparent about their usage as it helps set the right context for reviewers. Did you use AI tools to help write this code? **YES** — implemented with Claude Code (Sonnet 5): code analysis, the edits, build/check verification, and this PR description. 🤖 Generated with [Claude Code](https://claude.com/claude-code) https://claude.ai/code/session_01GnQV6onyMxKHxpRAjnuLL6 Co-authored-by: Claude Sonnet 5 <noreply@anthropic.com>
Co-authored-by: metoli86 <startangledbanner@gmail.com> Co-authored-by: Leopoldo Pla Sempere <leopoldo.pla@treelogic.com> Co-authored-by: Georgi Valchanov <138367360+iggydob@users.noreply.github.com> Co-authored-by: Alexander Matthes <ziz@mailbox.org> Co-authored-by: winst0niuss <chumachenko.vadym@gmail.com> Co-authored-by: Sara Zeaiter <zeaiter@condogroup.de> Co-authored-by: Stefan Blixten Karlsson <sbkarlsson@gmail.com> Co-authored-by: Matteo Scopel <matteo@scopel.email> Co-authored-by: Leopoldo Pla Sempere <leopoldoplasempere@gmail.com> Co-authored-by: crs <44726838+crsBug@users.noreply.github.com> Co-authored-by: muhas <muhas@muhas.ru>
Co-authored-by: Uri Tauber <uritaube@gmail.com> Co-authored-by: Sylve <43751434+s0lness@users.noreply.github.com>
Adapted from crosspoint-reader/crosspoint-reader@af82035 (crosspoint-reader#3618). Co-authored-by: Claude Opus 5 <noreply@anthropic.com>
Adapted from crosspoint-reader/crosspoint-reader@8c84ef3 (crosspoint-reader#3630), including the required Hangul composition behavior from f437bb5 (crosspoint-reader#3036). Co-authored-by: Justin Mitchell <justin@jmitch.com> Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 63ad4ede49
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New
Customize Status Bar > Percentage Format.Go to Stable Pagein the reader menu.Changed
Fixed
Notable features from upstream Crosspoint: