Repository navigation
Conversation
The toolkit's evidence JSON Schema is flagged by MEASURED on its own field names (mean_ttft_ms, p99_tpot_ms) and schema bounds. It is a published contract with no measured values, dataset, log or run result, and cannot be rewritten without changing contract 1.1.0. The review note explains the decision; the ledger entry binds the exact diff of PR #8 head 1d36d36 (blob 4918c81b..., fingerprint fb6cdf33...).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a central exact-diff review for
vLLM-HUST/vllm-ascend-quant-hust#8.contracts/ascend-quant-evidence-v1.schema.jsonis flagged byMEASUREDbecause the file is JSON and its published contract identifiers (mean_ttft_ms,p99_ttft_ms,mean_tpot_ms,p99_tpot_ms) sit next to JSON Schema bounds ("minimum": 0). The file defines the shape of the BF16/W8A8/W4A4/W4A8 evaluation record validated byascend-quant-toolkit validate-evidence; it contains no measured value, dataset, request log, timing or run result.It cannot be reworded without changing contract 1.1.0: the property names are the contract, and dropping their numeric bounds would let the schema accept records the toolkit rejects. Reformatting the JSON only to move digits out of the heuristic's 60-character window would evade the check rather than answer it, so the bytes are left exactly as published.
The review note records the reasoning. The ledger entry binds PR #8 head
1d36d36e7e7cececf8ffb6ae152aa05dd7307fd1: blob4918c81b324f3e4fbdfef1929f0474cdb17b318e, fingerprintfb6cdf33ba0121529a4803e634c72432a71635439eefa646f7ae9ed9d9f9a2d0. Verified with the central script on the live PR file list: this entry resolves the single remaining finding and nothing else.Rollout: after this merges, the toolkit repository pins the merge commit and passes
--repository/--pull-requestin a separate base-branch PR; PR #8 is then re-evaluated. The heuristics,DATA_PARTS,DATA_SUFFIXES, complete-list validation, removal semantics and the debt baseline are unchanged.