Skip to content

add dynamic handling timeout to processor options #51

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ttt161 merged 1 commit into from
Aug 6, 2026
+10 −2
Merged

add dynamic handling timeout to processor options #51

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions src/prg_worker_sidecar.erl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,17 +41,21 @@
-define(COMPLETION_KEY, progressor_task_completion_duration_ms).
-define(REMOVING_KEY, progressor_process_removing_duration_ms).
-define(NOTIFICATION_KEY, progressor_notification_duration_ms).
-define(DEFENSE_INTERVAL_MS, 50).

-dialyzer({nowarn_function, do_with_retry/2}).
%% API

%% processor wrapper
-spec process(pid(), timestamp_ms(), namespace_opts(), request(), context()) ->
{ok, _Result} | {error, _Reason} | no_return().
process(Pid, Deadline, #{namespace := NS} = NsOpts, {TaskType, _, _} = Request, Context) ->
process(Pid, Deadline, #{namespace := NS} = NsOpts0, {TaskType, _, _} = Request, Context) ->
Timeout = Deadline - erlang:system_time(millisecond),
NsOpts = add_handling_timeout(Timeout, NsOpts0),
%% Defense is needed to avoid race conditions with the processor
TimeoutWithDefense = Timeout + ?DEFENSE_INTERVAL_MS,
Fun = fun() ->
gen_server:call(Pid, {process, NsOpts, Request, Context, otel_ctx:get_current()}, Timeout)
gen_server:call(Pid, {process, NsOpts, Request, Context, otel_ctx:get_current()}, TimeoutWithDefense)
end,
prg_utils:with_observe(Fun, ?PROCESSING_KEY, [NS, erlang:atom_to_list(TaskType)], #{
name => atom_to_binary(?FUNCTION_NAME),
Expand Down Expand Up @@ -329,6 +333,10 @@ code_change(_OldVsn, #prg_sidecar_state{} = State, _Extra) ->
%%% Internal functions
%%%===================================================================

add_handling_timeout(Timeout, #{processor := ProcessorConf} = NsOpts) ->
ProcessorOpts = maps:get(options, ProcessorConf, #{}),
NsOpts#{processor => ProcessorConf#{options => ProcessorOpts#{handling_timeout => Timeout}}}.

do_with_retry(Fun, Delay) ->
try Fun() of
ok = Result ->
Expand Down
Loading