fix: synchronize pending Linux and subtitle fixes - #123
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f9f22beb5a
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| # The AppImage payload changed after Tauri produced updater artifacts. | ||
| # Regenerate its signature so latest.json always matches the release file. | ||
| rm -f "$APPIMAGE.sig" | ||
| bun run tauri signer sign "$APPIMAGE" |
There was a problem hiding this comment.
The signing credentials are scoped to the preceding tauri-action step, so this subsequent shell step does not receive TAURI_SIGNING_PRIVATE_KEY or its password. On every Linux release, after the AppImage is rebuilt and its original .sig is deleted, tauri signer sign will fail for lack of a private key and the release job cannot publish artifacts. Add the same signing env variables to this step (or promote them to job-level env).
Useful? React with 👍 / 👎.
| - name: Validate repaired Linux AppImage runtime | ||
| if: matrix.platform == 'ubuntu-22.04' | ||
| run: | | ||
| set -eu | ||
| APPIMAGE_DIR="src-tauri/target/${{ matrix.target }}/release/bundle/appimage" | ||
| APPIMAGE="$(find "$APPIMAGE_DIR" -maxdepth 1 -type f -name '*.AppImage' | sort | head -n 1)" | ||
| test -n "$APPIMAGE" | ||
| APPIMAGE="$(cd "$(dirname "$APPIMAGE")" && pwd)/$(basename "$APPIMAGE")" | ||
| bash scripts/repair-appimage-runtime.sh "$APPIMAGE" "Youwee" |
There was a problem hiding this comment.
This newly added validation invokes the repair script, whose preflight requires mksquashfs, but the build-test job's Linux dependency list does not install squashfs-tools; the package added in the separate check job is on a different runner. Consequently, on runner images without that preinstalled tool, the new AppImage validation exits before inspecting the rebuilt image and blocks CI. Install squashfs-tools in the build-test Linux dependencies as well.
Useful? React with 👍 / 👎.
1 participant
Summary
--sub-langs all#116Validation