Skip to content

fix: stabilize Flatpak WebKit runtime - #124

Merged
vanloctech merged 2 commits into
mainfrom
bugfix/issue-119
Sep 20, 2026
Merged

vanloctech merged 2 commits into
mainfrom
bugfix/issue-119

Conversation

@vanloctech

Copy link
Copy Markdown
Owner

Summary

Validation

  • bun run biome check --write .
  • bun run tsc -b
  • cargo check
  • pre-commit hook (102 tests)
  • GitHub Actions will build and launch the Flatpak bundle

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: f635cd7957

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +5 to +9
paths:
- '.github/workflows/flatpak-test.yml'
- 'flatpak/**'
- 'scripts/fix-deb-deep-link-desktop-entry.sh'
- 'src-tauri/**'

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Include frontend build inputs in the Flatpak PR paths

A PR that changes the React bundle or its build inputs (src/**, package.json, bun.lock, Vite configuration, etc.) matches none of these paths, so this workflow is skipped even though src-tauri/tauri.conf.json runs bun run build and packages ../dist into the .deb converted by this job. Such changes can introduce a packaged-app launch regression but will now be detected only after merging to main or during a tagged release; include the frontend/build inputs here or remove the restrictive filter.

Useful? React with 👍 / 👎.

@vanloctech
vanloctech merged commit 39bf1a9 into main Sep 20, 2026
4 checks passed
@vanloctech
vanloctech deleted the bugfix/issue-119 branch September 20, 2026 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant