Repository navigation
fix: call Knotree Registry through the in-cluster service - #9
Merged
Merged
Conversation
…lare Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
On prod,
POST /integrations/knotree-registry/authorize(and the callback) returnsREGISTRY_CONSENT_FAILED.Cloud's server-side calls to
https://registry.knotree.comgo out through Cloudflare, which can challenge datacenter traffic. Commit c3aa38e worked around the same problem for Accounts withSSO_SERVICE_ORIGIN.Changes
KNOTREE_REGISTRY_SERVICE_ORIGIN. Onlyhttp://registry.knotree-registry.svc.cluster.localis accepted; any other value falls back to the public URL with a warning.requestsandexchange, for both the account and the per-repository flows/auth/tokenauthorization_urlis still checked against the public URL. Registry builds that URL from its ownPUBLIC_REGISTRY_URL.REGISTRY_CONSENT_FAILED.optional_config, so preflight still passes before the variable is set.Test plan
cargo test: 120 passed, including the newserver_calls_only_use_the_in_cluster_registry_service.test_remote_gatefails locally only because Windows has no bash.🤖 Generated with Claude Code