fix(optics): keep observation records honest - #146
Merged
Merged
Conversation
zacharybalicki
force-pushed
the
cursor/optics-observe-fixes-c44b
branch
from
September 30, 2026 17:54
8d80d16 to
da00211
Compare
cursor
Bot
changed the base branch from
cursor/optics-remove-enforcement-c44b
to
main
September 30, 2026 17:57
kvantio
approved these changes
Sep 30, 2026
zacharybalicki
marked this pull request as ready for review
September 30, 2026 22:44
kvantio
approved these changes
Sep 30, 2026
kvantio
previously approved these changes
Sep 30, 2026
zacharybalicki
force-pushed
the
cursor/optics-observe-fixes-c44b
branch
from
October 1, 2026 00:11
da00211 to
ca01ec1
Compare
getresponse stores the HTTP status on the pending call and clears that pending state when it throws, so the next response is not attached to the failed request. VANTIO_INGEST_URL keeps its path. A worker thread's call stays on the shield run record. Rebased onto main after enforcement removal. Optics stays observe-only. CANDIDATE_ONLY. Not published.
zacharybalicki
force-pushed
the
cursor/optics-observe-fixes-c44b
branch
from
October 1, 2026 00:24
ca01ec1 to
ec9fe97
Compare
Member
Author
|
FOUNDER_OVERRIDE_MERGE (not Kate/
|
6 of 7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CANDIDATE_ONLY. No npm publish, no PyPI publish, and no install.vantio.ai go-live.
Kate queue
Order: #142 → #144 → #145 → #146 → #148 → #149 → PE #15 (#147 merged).
Approve exact head only (
kvantio). No admin bypass.Current head:
ec9fe97fc112d0ad81959807a098e26a465ea9e8Rebased onto main
a81df8b9dc3852326b8ce0b25f70fe8f70eae3f8(#145). No conflicts. Observe-only. Enforcement removed in #147 stays removed.What this does
Observation slice only (does not remove enforcement — that was #147).
http.clientstores the status fromgetresponse()and clears pending state when that call throws, so a later response is not attached to the failed request.VANTIO_INGEST_URLkeeps its path. A worker thread's call stays on the shield run record.The
http.clientsuccess path now records status 200 and a successful application outcome. A parent that already owns the HTTP call, such as urllib, does not have its record rewritten by this hook.Reproduction notes
http.clientrecorded the call atrequest()with no status. The regression test covers a throwngetresponse()and the next successful call.response.clone()throws was not reproduced on main. This branch does not defer the post into the clone callback.Do not merge until CI is green, independent council is PASS or PASS_WITH_NONBLOCKING_NOTES, and exact-head
kvantioAPPROVE.