Skip to content

Express changes before testing 9.1 #5

Description

@malikankit

I might be missing something here - since I am still trying to wrap my head around Router - so unsure if this is an issue.

Test: /, /bugs and any other URL for triggering a 404.
Before I can run the above test in 9.1 - wouldn't I require changes in webapp.js too - to make express point to 'router-rendering' ?)

Update :
When I test run / with the 9.1 code - I get a blank page.
Adding a browserHistory attribute to the JSX tag fixes it.

  1. Hazarding a guess, maybe the issue is because of different Router versions

  2. Strikethrough text - Intuitively, I was expecting some express code to point '/' to index.html and bundle.js to enable the Router routing code can take over. So I associated it to the blank page issue. I still need to wrap my head around how the routing code takes over - but I think this is unrelated to the issue above. :)

step-8.3...step-9.1

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions