Skip to content

fix(acpremote): negotiate acp.v1 optionally - #71

Merged
fswair merged 2 commits into
vcoderun:mainfrom
ejohb:fix/acp-v1-subprotocol
Oct 29, 2026
Merged

fswair merged 2 commits into
vcoderun:mainfrom
ejohb:fix/acp-v1-subprotocol

Conversation

@ejohb

@ejohb ejohb commented Oct 29, 2026

Copy link
Copy Markdown
Contributor

Description

Add native optional acp.v1 WebSocket subprotocol negotiation to the ACP remote servers.

Fixes: #67

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project (ruff format & check)
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings (basedpyright & ty)
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes (pytest)

Verification: Ruff format/check passed. All 7 tests in tests/acpremote/test_phase2.py, including the protocol-present and protocol-absent cases, passed. The broader tests/acpremote run stalled on its final Phase 3 test, so the full suite and basedpyright/ty checks remain unverified.

@fswair
fswair merged commit 126c9d3 into vcoderun:main Oct 29, 2026
53 checks passed
@fswair fswair mentioned this pull request Oct 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG]: WebSocket server does not negotiate acp.v1 subprotocol

2 participants