Repository navigation
feat(acpremote): accept bearer token from WebSocket subprotocol - #74
Merged
Merged
Conversation
Browser clients cannot set Authorization on WebSocket handshakes, so they send bearer.<token> next to acp.v1 in Sec-WebSocket-Protocol. The server now accepts that token and still only echoes acp.v1. Closes #73 Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Browser WebSocket clients (e.g. acp-ui) cannot set
Authorization, so they sendbearer.<token>inSec-WebSocket-Protocolalongsideacp.v1.is_bearer_authorizednow accepts theAuthorizationheader or abearer.<token>subprotocol entry, compared withhmac.compare_digest.Sec-WebSocket-Protocolheaders are treated as unauthorized instead of raising.acp.v1; the token is never reflected.Closes #73
Checked locally: ruff, ty, basedpyright,
tests/acpremote(60 passed,auth.py100%).🤖 Generated with Claude Code