ci(tests) Verify runtime deps#35
Conversation
Reviewer's Guide by SourceryThis pull request introduces a runtime dependency check in the CI pipeline to verify that the package functions correctly with its runtime dependencies before installing development dependencies. It also prints the package version and runs a basic functionality test during the check. No diagrams generated as the changes look simple and do not need a visual representation. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Hey @tony - I've reviewed your changes - here's some feedback:
Overall Comments:
- Consider adding a check that the CLI command
gis runnable as part of the runtime dependency test.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #35 +/- ##
=======================================
Coverage 76.24% 76.24%
=======================================
Files 5 5
Lines 181 181
=======================================
Hits 138 138
Misses 43 43 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Changes
uv run --no-devCHANGESSummary by Sourcery
Adds a CI check to verify runtime dependencies and basic functionality of the package.
CI:
uv run --no-devbefore installing dev dependencies.Tests: